From: Tzung-Bi Shih <tzungbi@kernel.org>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
linux-iio@vger.kernel.org, chrome-platform@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] iio: proximity: cros_ec_mkbp_proximity: Avoid -Wflex-array-member-not-at-end warning
Date: Mon, 17 Mar 2025 01:36:58 +0000 [thread overview]
Message-ID: <Z9d8uhMqHJ6K0nci@google.com> (raw)
In-Reply-To: <Z9dzDB1gttXehYGO@kspp>
On Mon, Mar 17, 2025 at 11:25:40AM +1030, Gustavo A. R. Silva wrote:
> static int cros_ec_mkbp_proximity_query(struct cros_ec_device *ec_dev,
> int *state)
> {
> - struct {
> - struct cros_ec_command msg;
> - union {
> - struct ec_params_mkbp_info params;
> - u32 switches;
> - };
> - } __packed buf = { };
> - struct ec_params_mkbp_info *params = &buf.params;
> - struct cros_ec_command *msg = &buf.msg;
> - u32 *switches = &buf.switches;
> + DEFINE_RAW_FLEX(struct cros_ec_command, buf, data, sizeof(u32));
max(sizeof(struct ec_params_mkbp_info), sizeof(u32))?
next prev parent reply other threads:[~2025-03-17 1:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 0:55 [PATCH][next] iio: proximity: cros_ec_mkbp_proximity: Avoid -Wflex-array-member-not-at-end warning Gustavo A. R. Silva
2025-03-17 1:36 ` Tzung-Bi Shih [this message]
2025-03-17 12:08 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9d8uhMqHJ6K0nci@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=gustavoars@kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox