From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Mike Looijmans <mike.looijmans@topic.nl>,
devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
Caleb Connolly <caleb.connolly@linaro.org>,
ChiYuan Huang <cy_huang@richtek.com>,
ChiaEn Wu <chiaen_wu@richtek.com>,
Cosmin Tanislav <demonsingur@gmail.com>,
Ibrahim Tilki <Ibrahim.Tilki@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Ramona Bolboaca <ramona.bolboaca@analog.com>,
William Breathitt Gray <william.gray@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] iio: adc: Add TI ADS1100 and ADS1000
Date: Mon, 6 Mar 2023 14:11:48 +0200 [thread overview]
Message-ID: <ZAXYhIETzMa/7G6N@smile.fi.intel.com> (raw)
In-Reply-To: <20230304175751.2daae308@jic23-huawei>
On Sat, Mar 04, 2023 at 05:57:51PM +0000, Jonathan Cameron wrote:
> On Tue, 28 Feb 2023 07:31:51 +0100
> Mike Looijmans <mike.looijmans@topic.nl> wrote:
...
> > + for (i = 0; i < 4; i++) {
> > + if (BIT(i) == gain) {
> > + ads1100_set_config_bits(data, ADS1100_PGA_MASK, i);
> > + return 0;
> > + }
> > + }
> Andy's suggestion of something like..
> if (!gain)
> return -EINVAL;
> i = ffs(gain);
> if (i >= 4 || BIT(i) != gain)
> return -EINVAL;
>
> ads...
>
> Is perhaps nicer than the loop.
Even better:
if (!gain || !is_power_of_2(gain))
return -EINVAL;
i = ffs(gain);
if (i >= 4)
return -EINVAL;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-06 12:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 6:31 [PATCH v3 1/2] dt-bindings: iio: adc: Add TI ADS1100 and ADS1000 Mike Looijmans
2023-02-28 6:31 ` [PATCH v3 2/2] " Mike Looijmans
2023-03-01 15:30 ` Andy Shevchenko
2023-03-02 7:49 ` Mike Looijmans
2023-03-02 13:16 ` Lars-Peter Clausen
2023-03-02 13:20 ` Lars-Peter Clausen
2023-03-02 14:24 ` Andy Shevchenko
2023-03-04 17:19 ` Jonathan Cameron
2023-03-02 14:23 ` Andy Shevchenko
2023-03-04 17:26 ` Jonathan Cameron
2023-03-06 12:09 ` Andy Shevchenko
2023-03-04 17:57 ` Jonathan Cameron
2023-03-06 6:31 ` Mike Looijmans
2023-03-06 11:21 ` Mike Looijmans
2023-03-12 14:53 ` Jonathan Cameron
2023-03-06 12:11 ` Andy Shevchenko [this message]
2023-03-06 12:16 ` Andy Shevchenko
2023-03-06 12:20 ` Andy Shevchenko
2023-03-06 12:56 ` Mike Looijmans
2023-03-06 13:19 ` Andy Shevchenko
2023-02-28 10:34 ` [PATCH v3 1/2] dt-bindings: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAXYhIETzMa/7G6N@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Ibrahim.Tilki@analog.com \
--cc=caleb.connolly@linaro.org \
--cc=chiaen_wu@richtek.com \
--cc=cy_huang@richtek.com \
--cc=demonsingur@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=ramona.bolboaca@analog.com \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox