From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F2FCC61DA4 for ; Sat, 11 Mar 2023 19:05:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229934AbjCKTFS (ORCPT ); Sat, 11 Mar 2023 14:05:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229839AbjCKTFR (ORCPT ); Sat, 11 Mar 2023 14:05:17 -0500 Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C79ED64232 for ; Sat, 11 Mar 2023 11:05:15 -0800 (PST) Received: by mail-qt1-x82b.google.com with SMTP id c3so9350699qtc.8 for ; Sat, 11 Mar 2023 11:05:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678561515; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Rbfswi8F0tvm4TB1oEfjIUGvqcw32tOuUkfi+zA3fKw=; b=isog/hOcdR0ifh9gwT9ytZpi/1TJ1sGvjtWA9jWbewn5sb1LhFPYqwjJanA1Ruy9/r rtD1Ojyzd+2xcZw9IZ1a26aAkJ8Y3RdOuxJM1nDSMgl6VEVYhNrh7u8ojRu2+TOywzrv 8uiqP4Bbr3AUhO5xncn1Ba39xuUG82QSlpR/Yq1SM+gZQkrfWqaKsn67x8VhWJ5xwDHJ aKD/3wFnYvMERio00Tq28Op3kwiOwtzNveqHeQNzPf/A+6wjAZcogh9Tm9xtw8FqNe5Q yNb2lWpyGYz4sW6ZO+d6jPm3EsAcjBIYFpd6qD/A32k0oUaMKc8MVxz2/tjdfsZTm9jG Ueqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678561515; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Rbfswi8F0tvm4TB1oEfjIUGvqcw32tOuUkfi+zA3fKw=; b=VrDNVOTZ0rDgcCYe/WPH85ZsIlBl/XLROYrUu87rwqc/tT11oovJaLIhK7OkjgMN4R hBBb1E7genk56tz2V1WAejgRtfYxbgCq4hL0iqa3r5r3wAblw5xkZ7fNIzA5a7aioDYf 3O/FmeFCmJOxTk7aK7NRm8cYP+TWr8l9bATcAK3hWS+7h9fnH1HIE3SLS1PCaxsOXqL0 BN6L8XJWmJ20/2/LhhGkd/Y2ldkYkus6Rh8M6rp+3rAifCZaZuhtPawbCIrpMD65nw9i NRKjQN4SzAsLa3KchHte29KoEMu7HzwaOSW6Nj7TgIzf+mVRBhyk7cP3V4LH8ERepdy9 7BWw== X-Gm-Message-State: AO0yUKVjtwTEsxn8h7CT2lG9wFdtEUBvyzm67OQ9CuAw92fSrIQ69pB7 ILW2F0Bxpon9DF89B5bSkx+iVw== X-Google-Smtp-Source: AK7set8yXHbkrDKo9BiVAsqxPSADoxC9ajohxwr6pGdGG8Vk74ehqQzfvnlYxcWaedXAo35janM3nQ== X-Received: by 2002:a05:622a:83:b0:3bf:da69:6107 with SMTP id o3-20020a05622a008300b003bfda696107mr48730811qtw.67.1678561514875; Sat, 11 Mar 2023 11:05:14 -0800 (PST) Received: from fedora (69-109-179-158.lightspeed.dybhfl.sbcglobal.net. [69.109.179.158]) by smtp.gmail.com with ESMTPSA id w23-20020a05620a0e9700b0073bacce6ad7sm2184377qkm.82.2023.03.11.11.05.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 11:05:14 -0800 (PST) Date: Sat, 11 Mar 2023 14:05:12 -0500 From: William Breathitt Gray To: Jonathan Cameron Cc: lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko Subject: Re: [PATCH v2] iio: dac: cio-dac: Migrate to the regmap API Message-ID: References: <20230311140218.74920-1-william.gray@linaro.org> <20230311185719.7af38a8a@jic23-huawei> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gdSAI13kS9LQ1z0A" Content-Disposition: inline In-Reply-To: <20230311185719.7af38a8a@jic23-huawei> Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org --gdSAI13kS9LQ1z0A Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 11, 2023 at 06:57:19PM +0000, Jonathan Cameron wrote: > On Sat, 11 Mar 2023 09:02:18 -0500 > William Breathitt Gray wrote: > > diff --git a/drivers/iio/dac/cio-dac.c b/drivers/iio/dac/cio-dac.c > > index 791dd999cf29..759833a6bd29 100644 > > --- a/drivers/iio/dac/cio-dac.c > > +++ b/drivers/iio/dac/cio-dac.c > > @@ -6,16 +6,15 @@ > > * This driver supports the following Measurement Computing devices: C= IO-DAC16, > > * CIO-DAC06, and PC104-DAC06. > > */ > > -#include > > +#include >=20 > I'm not immediately spotting why this change is part of the regmap > conversion. >=20 > It may well make sense, but if unrelated, should probably be in a differe= nt patch. No you're right, this is an unrelated cleanup that I should probably have pulled out to its own dedicated patch. If there is a need for a v3, I'll split this off and submit it separately. William Breathitt Gray --gdSAI13kS9LQ1z0A Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZAzQ6AAKCRC1SFbKvhIj KxfEAQC3HNpmFWAkWMGkhGrkKmzcQxNcUC1NNFwA3SJHUyAqDgEAlgvrzVmYbfQY dx/LDVo9zCyk6h39l2Ys4VwxSnM5Fg4= =OXGt -----END PGP SIGNATURE----- --gdSAI13kS9LQ1z0A--