From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05021C77B61 for ; Tue, 25 Apr 2023 13:45:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234127AbjDYNp1 (ORCPT ); Tue, 25 Apr 2023 09:45:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229915AbjDYNp0 (ORCPT ); Tue, 25 Apr 2023 09:45:26 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D7FD19BC; Tue, 25 Apr 2023 06:45:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682430325; x=1713966325; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=k/ABWJ2xxNYCYrGZUiTvjqFyFuCe4XdVVI+pcOUNIv8=; b=A4CO2wCD+vygGngqhNi+C+Juzoch3wTbsnSvCRehfyXVtkDiuxwfE3WX /aB2Ei0evzE/1jAnqfhG7gY77tlwg3Wn71bz5v7aat7PAqiEp2Ybl/M2v l3I94t4MXKYonXy3vjfF63iISI6TE8TPiIGiij4p1qY0jCRmxQZk31PaX GPwKH12kCprch3WT0xQ5I0R/+mMKBtAILxNi7DdFeZMyRt76FwsAUhUF7 YpVdPmQfxr1ejB7fGKkZo8Twq/os0cO4Fmp8GB6PYxDYwGdJcDYA87tJJ uNb036Bl2REMitKaBq9dnBmCFGaDukrQFTqYtnNFg8fqPSMiuGWqjMtfh A==; X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="345521094" X-IronPort-AV: E=Sophos;i="5.99,225,1677571200"; d="scan'208";a="345521094" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2023 06:45:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="724036501" X-IronPort-AV: E=Sophos;i="5.99,225,1677571200"; d="scan'208";a="724036501" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP; 25 Apr 2023 06:45:21 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1prIyt-00505G-0n; Tue, 25 Apr 2023 16:45:19 +0300 Date: Tue, 25 Apr 2023 16:45:18 +0300 From: Andy Shevchenko To: Matti Vaittinen Cc: Matti Vaittinen , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Zhigang Shi , Shreeya Patel , Paul Gazzillo , Dmitry Osipenko , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/5] iio: light: ROHM BU27008 color sensor Message-ID: References: <47998ed8-5160-69dd-1767-e1746971a9b9@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47998ed8-5160-69dd-1767-e1746971a9b9@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, Apr 25, 2023 at 08:24:01AM +0300, Matti Vaittinen wrote: > On 4/24/23 18:22, Andy Shevchenko wrote: > > On Mon, Apr 24, 2023 at 04:10:09PM +0300, Matti Vaittinen wrote: ... > > This... > > > > > +#include > > > > ...is guaranteed to be included by this. > > > > > +#include > > Out of the curiosity - do we have a rule and rationale for explicitly > including headers with 'stuff' we use Vs. trusting some header being > included by another one? I've not thought much of this so I don't know if > there are any pros/cons? That's what we are starving for actually. Currently this is a tribe knowledge which one gets while being involved into Linux kernel development for a long time and being capable of keeping an eye on tree wide, library or similar changes. I would love to see some (preferably generated) list of the header dependencies. Yet, the header dependency hell should be solved meanwhile (see Ingo's 2k+ patch series). -- With Best Regards, Andy Shevchenko