From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A6D7C77B73 for ; Fri, 19 May 2023 01:27:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229995AbjESB1G (ORCPT ); Thu, 18 May 2023 21:27:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230186AbjESB1F (ORCPT ); Thu, 18 May 2023 21:27:05 -0400 Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C87BD128 for ; Thu, 18 May 2023 18:27:03 -0700 (PDT) Received: by mail-yb1-xb35.google.com with SMTP id 3f1490d57ef6-ba6d024a196so2403874276.2 for ; Thu, 18 May 2023 18:27:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684459623; x=1687051623; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1lvP7Q1DPXjSG9iBptgkojp087iyFGiylW3zAHv1G0s=; b=vOVrSlpzLvgAwRxr0Q+rmluXHst7drYbuTE/FlnkA0sI0Vq+REfrWisZRfc1SzSbgw tVsm1pXic0P6GJDF2/7zkD8ER83IoVL7aMp/bHPVrAHQkbbixm3Kg0HMLS35H/xAyVl+ UTmOzWe+uQHcb5OYgXl4x58ilZsw3U0w8CB/8DRxqCAwNxEdqhyYWM9g8qj7xVjIwSzv RagYDOY7DuNgn/2/x2NdIprh8X8N+/x5WsqWtdLmu0RBcEsmDgIcvf39Vl0lvfYzI66p MeMDa4CFtzCaOZN4K8cznxO5u8tCBERtUczXNEkQCmNWKWb8p/nq25Dyc4YI11GlL9x7 1/nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684459623; x=1687051623; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1lvP7Q1DPXjSG9iBptgkojp087iyFGiylW3zAHv1G0s=; b=XG4X1FGGuxwRP7nWJsNiNZTRd0HPYm1Iw4OFoQdNR12z4lsU7aEPArGl7QJFvynVGY Q5ekZfdnTL1HADIz/HGzORU/eD97ESmqg8nbiJAvrxvQ9ask5wfdL0yJBjw7f1c8hxzC FR//MeRt4SxZBlNjah61ZXwJjBi8EEAG9jUmPZR432HX5otAHxva0B41IZTMCP8yDYdG uZrSBORbQ/JEhyBwIEUBdlAIo1PBSiQWK6u7XAnNyeDsacuDtKzy3OsZvSkmDlSXohR4 dEQ+p2QblKRabxnlB0TwC0LWS2lZvlC8QrGuWssx1ttAvgm2lAkk8laRjELF89OsY3tt 89RA== X-Gm-Message-State: AC+VfDzdkF6RM8k6d7ZyPvFH6HIp60WUjouwus3z1zwUksGnCmi3HYXk CT/rpmxNw4Eie6EepE/WvNx75A== X-Google-Smtp-Source: ACHHUZ60fWA8dMxrxSEEE9Cq6HNL+5hZBH8mz2lPQkgrGsomWHcS7zVmJG4fADlLH1bX8uxE4zKyvA== X-Received: by 2002:a25:c7cb:0:b0:b8f:6cd0:4ef1 with SMTP id w194-20020a25c7cb000000b00b8f6cd04ef1mr192327ybe.17.1684459622935; Thu, 18 May 2023 18:27:02 -0700 (PDT) Received: from fedora (69-109-179-158.lightspeed.dybhfl.sbcglobal.net. [69.109.179.158]) by smtp.gmail.com with ESMTPSA id x6-20020a259c46000000b00b9ba6a3b675sm699871ybo.50.2023.05.18.18.27.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 18:27:02 -0700 (PDT) Date: Thu, 18 May 2023 21:26:59 -0400 From: William Breathitt Gray To: Niklas Schnelle Cc: Arnd Bergmann , Greg Kroah-Hartman , Bjorn Helgaas , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Mauro Carvalho Chehab , Alan Stern , "Rafael J. Wysocki" , Geert Uytterhoeven , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, Arnd Bergmann , linux-iio@vger.kernel.org Subject: Re: [PATCH v4 05/41] counter: add HAS_IOPORT dependencies Message-ID: References: <20230516110038.2413224-1-schnelle@linux.ibm.com> <20230516110038.2413224-6-schnelle@linux.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5bxTSeSIiawlWPZU" Content-Disposition: inline In-Reply-To: <20230516110038.2413224-6-schnelle@linux.ibm.com> Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org --5bxTSeSIiawlWPZU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 16, 2023 at 01:00:01PM +0200, Niklas Schnelle wrote: > In a future patch HAS_IOPORT=3Dn will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. >=20 > Co-developed-by: Arnd Bergmann > Signed-off-by: Arnd Bergmann > Signed-off-by: Niklas Schnelle Hi Niklas, The change itself is fine, but please update the description to reflect that this is adding a depends on HAS_IOPORT_MAP rather than HAS_IOPORT, along with the reason why it's needed (i.e. devm_ioport_map() is used). Thanks, William Breathitt Gray > --- > Note: The HAS_IOPORT Kconfig option was added in v6.4-rc1 so > per-subsystem patches may be applied independently >=20 > drivers/counter/Kconfig | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig > index 4228be917038..e65a2bf178b8 100644 > --- a/drivers/counter/Kconfig > +++ b/drivers/counter/Kconfig > @@ -15,6 +15,7 @@ if COUNTER > config 104_QUAD_8 > tristate "ACCES 104-QUAD-8 driver" > depends on (PC104 && X86) || COMPILE_TEST > + depends on HAS_IOPORT_MAP > select ISA_BUS_API > help > Say yes here to build support for the ACCES 104-QUAD-8 quadrature > --=20 > 2.39.2 >=20 --5bxTSeSIiawlWPZU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZGbQYwAKCRC1SFbKvhIj Kwr/AP9BDmkAnBXC+MjVSJOmxTQF8Sx5RdpwwV0Oaq8V32L4cAEAjgIcBwlTHN/4 SwcgWo1pJaiaLAG8+7C20VWkinQ4dwc= =WkDE -----END PGP SIGNATURE----- --5bxTSeSIiawlWPZU--