From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D09CC77B7F for ; Fri, 19 May 2023 14:21:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231148AbjESOVP (ORCPT ); Fri, 19 May 2023 10:21:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230391AbjESOVO (ORCPT ); Fri, 19 May 2023 10:21:14 -0400 Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B453A1A5 for ; Fri, 19 May 2023 07:21:12 -0700 (PDT) Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-561c1436c75so51711797b3.1 for ; Fri, 19 May 2023 07:21:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684506072; x=1687098072; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jD0yVuhNIJ7sH/WR7FfoCKVL3m6JfoadwNdrAx1+BfI=; b=k3Q7zCJd7SrM6WeO4BXv32omMuNfNO8xoS1Nt+7oOVxgtcmcRkzXN9nUaUZthvaeMx 2pZFH6Hzncg+O0DjEkEGbSr28Ewlj1j3BRCKSML2FbRbd9eW+kiQymgS+9Vdd+gGyb/G b2NOKgCVlGUxDF2lGvX4J3eQpXD4upxY3yQRBmkAyvhZiQtcS1W65W+WbXNEC5FoRCmJ pk7dhUYd+EpUR09+fVRjmEScDNJJ0iXrXarZyeVdjVem16N+5ihl77p515rZI2A7bAqo 4aNDHgYn1ut0uFOynwVqkIiWs5Zb8BNkpbMdfbhoe195SuluhfKNtlpTWtNeTn2e7Tbi dSWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684506072; x=1687098072; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jD0yVuhNIJ7sH/WR7FfoCKVL3m6JfoadwNdrAx1+BfI=; b=W4mk0aCXJKhd9qUryjU+B7LKHQDOEOpsEIgecaDjrZEjIfJsD4wmU2JqN1OZZ+hQit Lt+VLaANT73ktSTRIyvV5LdPm6BAUogiNx6yTc3Sxdt3tScg0SlvXAEVCaOqcuUYl2fX BftHg4NgZaJMfJ86U3hoxqjCuR21B74KZUCIXzqKP8trNkWul0cEVmJt24aAw2IMtk3a QDCcRQ6KLWN2Of4eZcVPyo7OCQ6K1TWQ9O7obs9n8HDcIrxRt+/Ew9u56glxNZ8U1HJh o4e2GQ6CgRBTsvm7pWnkdVHH+e/sWWgb30VavHBlGSUzgk0SmJedm3dSCwEyluBU0YLq LPig== X-Gm-Message-State: AC+VfDyY9yEsxFZuwsMcSSb5ZIJyVaWGEwCHRp6NDQxVA+K0tZhbhxTe ybnmha8Vbj+uAv5YryOcRtNMKA== X-Google-Smtp-Source: ACHHUZ6NsUlRU62aztZHG3BPnNcjT59T5yuWn3x8G1LBoK7m3LHMEqTd3W6SzUBZR5s1puYI+P7FSQ== X-Received: by 2002:a81:5247:0:b0:561:c5c3:9d79 with SMTP id g68-20020a815247000000b00561c5c39d79mr1895406ywb.45.1684506071882; Fri, 19 May 2023 07:21:11 -0700 (PDT) Received: from fedora (69-109-179-158.lightspeed.dybhfl.sbcglobal.net. [69.109.179.158]) by smtp.gmail.com with ESMTPSA id r187-20020a815dc4000000b00545a08184bbsm1189286ywb.75.2023.05.19.07.21.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 May 2023 07:21:11 -0700 (PDT) Date: Fri, 19 May 2023 10:21:08 -0400 From: William Breathitt Gray To: Niklas Schnelle Cc: Arnd Bergmann , Greg Kroah-Hartman , Bjorn Helgaas , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Mauro Carvalho Chehab , Alan Stern , "Rafael J. Wysocki" , Geert Uytterhoeven , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, Arnd Bergmann , linux-iio@vger.kernel.org Subject: Re: [PATCH v4 05/41] counter: add HAS_IOPORT dependencies Message-ID: References: <20230516110038.2413224-1-schnelle@linux.ibm.com> <20230516110038.2413224-6-schnelle@linux.ibm.com> <6f4d672ba7136f2b01ea9ee69687b16168eddb8d.camel@linux.ibm.com> <231dcebc57c2e43ba65d007b60d3d446d9ed71c8.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EBH9/xbXifix297d" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org --EBH9/xbXifix297d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 19, 2023 at 03:39:57PM +0200, Niklas Schnelle wrote: > On Fri, 2023-05-19 at 15:38 +0200, Niklas Schnelle wrote: > > On Fri, 2023-05-19 at 15:17 +0200, Niklas Schnelle wrote: > > > On Thu, 2023-05-18 at 21:26 -0400, William Breathitt Gray wrote: > > > > On Tue, May 16, 2023 at 01:00:01PM +0200, Niklas Schnelle wrote: > > > > > In a future patch HAS_IOPORT=3Dn will result in inb()/outb() and = friends > > > > > not being declared. We thus need to add HAS_IOPORT as dependency = for > > > > > those drivers using them. > > > > >=20 > > > > > Co-developed-by: Arnd Bergmann > > > > > Signed-off-by: Arnd Bergmann > > > > > Signed-off-by: Niklas Schnelle > > > >=20 > > > > Hi Niklas, > > > >=20 > > > > The change itself is fine, but please update the description to ref= lect > > > > that this is adding a depends on HAS_IOPORT_MAP rather than HAS_IOP= ORT, > > > > along with the reason why it's needed (i.e. devm_ioport_map() is us= ed). > > > >=20 > > > > Thanks, > > > >=20 > > > > William Breathitt Gray > > > >=20 > > > >=20 > > >=20 > > > Right, this clearly needs adjustment. I went with the following commit > > > message for v5: > > >=20 > > > "counter: add HAS_IOPORT_MAP dependency > > >=20 > > > The 104_QUAD_8 counter driver uses devm_ioport_map() without depending > > > on HAS_IOPORT_MAP. This causes compilation to fail on platforms such = as > > > s390 which do not support I/O port mapping. Add the missing > > > HAS_IOPORT_MAP dependency to fix this." > > >=20 > >=20 > > Just noticed this isn't entirely correct. As devm_ioport_map() has an > > empty stub for HAS_IOPORT_MAP=3Dn this doesn't lead to a compile error = it > > just doesn't work. Will reword to "This causes the driver to not be > > useable on platforms ..." >=20 > s/useable/usable/ 104_QUAD_8 has an explicit dependency on PC104 and X86, so I don't think it would ever be used outside of x86 platforms. Does it still make sense to have the HAS_IOPORT_MAP dependency in this case? William Breathitt Gray --EBH9/xbXifix297d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZGeF1AAKCRC1SFbKvhIj K453AP9zNn9wgYcEBDa5y15FH8KKUQSfyNCaUMKyjOcLaFoeEQEAiYcdE/TNd4HS t4Z4xU0Ws5yWOLB4p4wMFw+18EyLmQM= =BAPi -----END PGP SIGNATURE----- --EBH9/xbXifix297d--