From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5A72C77B73 for ; Sat, 3 Jun 2023 11:24:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229951AbjFCLYd (ORCPT ); Sat, 3 Jun 2023 07:24:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229644AbjFCLYb (ORCPT ); Sat, 3 Jun 2023 07:24:31 -0400 Received: from fgw20-7.mail.saunalahti.fi (fgw20-7.mail.saunalahti.fi [62.142.5.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 639D8180 for ; Sat, 3 Jun 2023 04:24:30 -0700 (PDT) Received: from localhost (88-113-26-95.elisa-laajakaista.fi [88.113.26.95]) by fgw20.mail.saunalahti.fi (Halon) with ESMTP id 33b6a7c0-0201-11ee-b3cf-005056bd6ce9; Sat, 03 Jun 2023 14:24:28 +0300 (EEST) From: andy.shevchenko@gmail.com Date: Sat, 3 Jun 2023 14:24:28 +0300 To: inv.git-commit@tdk.com Cc: jic23@kernel.org, linux-iio@vger.kernel.org, lars@metafoo.de, Jean-Baptiste Maneyrol Subject: Re: [PATCH 0/4] Factorize timestamp module Message-ID: References: <20230531142513.48507-1-inv.git-commit@tdk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230531142513.48507-1-inv.git-commit@tdk.com> Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Wed, May 31, 2023 at 02:25:09PM +0000, inv.git-commit@tdk.com kirjoitti: > From: Jean-Baptiste Maneyrol > > The purpose if this series is to make timestamping from > inv_icm42600 driver an independent module and use it for both > inv_icm42600 and inv_mpu6050 drivers. > > Create a new inv_sensors_timestamp common module based on > inv_icm42600 driver and use it in the 2 drivers. > > WARNING: this patch requires following commit in fixes-togreg > bbaae0c79ebd ("iio: imu: inv_icm42600: fix timestamp reset") This is so nicely prepared series, but I have a few style nit-picks (individually commented) and one to address, i.e. kernel.h inclusion. With that addressed, Reviewed-by: Andy Shevchenko Thank you! -- With Best Regards, Andy Shevchenko