From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F64AEB64D9 for ; Wed, 12 Jul 2023 11:04:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231857AbjGLLEN (ORCPT ); Wed, 12 Jul 2023 07:04:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232145AbjGLLEM (ORCPT ); Wed, 12 Jul 2023 07:04:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56ED31703; Wed, 12 Jul 2023 04:04:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DF4A161757; Wed, 12 Jul 2023 11:04:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E70C5C433C7; Wed, 12 Jul 2023 11:04:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689159850; bh=rdm8WjXKH/Znp0e9wHbJbC6k/jQWaZx00+D9CSaZnPU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nbz9+/NWkxFQdbyjChz27t9IXpRfWc6BNaglL3SF1Q3Tp8OOTXUBHPjQv4s3LKhow 88Z6aWaBoDxnkx6A4QTaGoOEIX9RU98sGOb/RoHe/Ant5XWIkPBgzq9MQzjn8sTl7s d9ycxbbnNuRjm2g+ItMSS30+ynn8eeThv7186OnVGJ8TH/ELq6BL+OBKgEYMP4fw4m Ove5LyP6fG5+sOP+p9MJo+meTYlxgwYwubeE5/0ts5kEwYFI4kRjRDGV9ytJv5K2yb 1opDdMrG00jrJBBQ8AihNvSfLQes3j5FZ+W83M1Vtha+1MWLlUxsFatNVLRu+5S8yF dGPQ1j6i6VNGQ== Date: Wed, 12 Jul 2023 13:04:05 +0200 From: Lorenzo Bianconi To: Alejandro Tafalla Cc: jic23@kernel.org, lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH] iio: imu: lsm6dsx: Fix mount matrix retrieval Message-ID: References: <12960181.O9o76ZdvQC@alexpc> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="a1ZHb+yY60egR0aD" Content-Disposition: inline In-Reply-To: <12960181.O9o76ZdvQC@alexpc> Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org --a1ZHb+yY60egR0aD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > The function lsm6dsx_get_acpi_mount_matrix should return true when ACPI > support is not enabled to allow executing iio_read_mount_matrix in the > probe function. >=20 > Fixes: dc3d25f22b88 ("iio: imu: lsm6dsx: Add ACPI mount matrix retrieval") >=20 > Signed-off-by: Alejandro Tafalla > --- > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/i= mu/ > st_lsm6dsx/st_lsm6dsx_core.c > index 6a18b363cf73..62bc3ee783fb 100644 > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > @@ -2687,7 +2687,7 @@ static int lsm6dsx_get_acpi_mount_matrix(struct dev= ice=20 > *dev, > static int lsm6dsx_get_acpi_mount_matrix(struct device *dev, > struct=20 > iio_mount_matrix *orientation) > { > - return false; > + return true; I would say it should return something like -EOPNOTSUPP. Regards, Lorenzo > } > =20 > #endif > --=20 > 2.41.0 >=20 >=20 >=20 >=20 --a1ZHb+yY60egR0aD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZK6IoQAKCRA6cBh0uS2t rLw5AP97OM4FyYf1bRULy7a0yrejqbRvsTYgBHpnO3Okk3GF+AEA3xnWcjF4LTAO o3VyGdcNfSq9Vx8lFJwnzaZ/MsMAwAc= =rqcn -----END PGP SIGNATURE----- --a1ZHb+yY60egR0aD--