From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Peter Rosin" <peda@axentia.se>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Crt Mori" <cmo@melexis.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
linux-iio@vger.kernel.org,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: magnetometer: ak8975: Simplify probe()
Date: Tue, 8 Aug 2023 16:05:48 +0300 [thread overview]
Message-ID: <ZNI9rIWa7bxNW9+P@smile.fi.intel.com> (raw)
In-Reply-To: <20230807172548.258247-2-biju.das.jz@bp.renesas.com>
On Mon, Aug 07, 2023 at 06:25:48PM +0100, Biju Das wrote:
> Simplify the probe() by replacing device_get_match_data() and
> i2c_client_get_device_id by i2c_get_match_data() as we have similar I2C,
> ACPI and DT matching table.
...
> - name = dev_name(&client->dev);
> - name = id->name;
> - indio_dev->name = name;
> + indio_dev->name = dev_name(&client->dev);
I believe this is an ABI breakage.
NAK.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-08 16:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 17:25 [PATCH 1/2] iio: magnetometer: yamaha-yas530: Use i2c_get_match_data() Biju Das
2023-08-07 17:25 ` [PATCH 2/2] iio: magnetometer: ak8975: Simplify probe() Biju Das
2023-08-08 13:05 ` Andy Shevchenko [this message]
2023-08-11 12:17 ` Biju Das
2023-08-28 13:06 ` Jonathan Cameron
2023-08-08 13:04 ` [PATCH 1/2] iio: magnetometer: yamaha-yas530: Use i2c_get_match_data() Andy Shevchenko
2023-08-11 7:49 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNI9rIWa7bxNW9+P@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=cmo@melexis.com \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=peda@axentia.se \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox