From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9656AC001DB for ; Tue, 8 Aug 2023 17:05:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231229AbjHHRFn (ORCPT ); Tue, 8 Aug 2023 13:05:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231394AbjHHRE5 (ORCPT ); Tue, 8 Aug 2023 13:04:57 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AFB11A744; Tue, 8 Aug 2023 09:02:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691510527; x=1723046527; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=XveRea9FANQPUg2+NGfW1ls9tlTN5Z18q/yQQW52Pdg=; b=eLl/B+C6sBC8bNHtExz3HCdThPt5hLYA8yttYiQaKVGc9dfy/1XvdrGs rEfaDAFJyBXWIeFXgLled8Mt6sYQxuCxAgaiDWefQS/efHAXi2xRlgGoQ avBAqH3GDMwnNOMZ3/iGKd4z3kW7t9QF8rbziuaTngdvEpyCqoLJ9tqUR 7DV1uuPYGez7wQN74dHO/WrylRuvMmR/MGwiG3DneNTNZj9NxDwOfS1gJ pqZLCnN8xRiaOUXEzzsnOz+6vcTF5HqK/hVLYeHEe6xyAZKAc++vdfHYa 7IC4ktsUmotG6zwOY4uAgJvB+ahfic+ke+7yDFvXdsTtsaqdZs/G01gpC A==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="373581385" X-IronPort-AV: E=Sophos;i="6.01,156,1684825200"; d="scan'208";a="373581385" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2023 07:13:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="801337918" X-IronPort-AV: E=Sophos;i="6.01,156,1684825200"; d="scan'208";a="801337918" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 08 Aug 2023 07:13:28 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qTNSg-00BIxZ-0M; Tue, 08 Aug 2023 17:13:26 +0300 Date: Tue, 8 Aug 2023 17:13:25 +0300 From: Andy Shevchenko To: Marcus Folkesson Cc: Kent Gustavsson , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Cosmin Tanislav , Arnd Bergmann , ChiYuan Huang , Haibo Chen , Ramona Bolboaca , Ibrahim Tilki , ChiaEn Wu , William Breathitt Gray , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/4] iio: adc: mcp3911: fix indentation Message-ID: References: <20230808110432.240773-1-marcus.folkesson@gmail.com> <20230808110432.240773-3-marcus.folkesson@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230808110432.240773-3-marcus.folkesson@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, Aug 08, 2023 at 01:04:31PM +0200, Marcus Folkesson wrote: > The file does not make use of indentation properly. > Fix that. ... > static int mcp3911_update(struct mcp3911 *adc, u8 reg, u32 mask, > - u32 val, u8 len) > + u32 val, u8 len) Can val be moved to the previous line? ... > if (ret < 0) { > dev_err(&adc->spi->dev, > "failed to get vref voltage: %d\n", > - ret); > + ret); > return ret; With struct device *dev = &adc->spi->dev; this becomes dev_err(dev, "failed to get vref voltage: %d\n", ret); and one change less here. > } ... > -#define MCP3911_CHAN(idx) { \ > - .type = IIO_VOLTAGE, \ > - .indexed = 1, \ > - .channel = idx, \ > - .scan_index = idx, \ > - .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO), \ > - .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \ > - BIT(IIO_CHAN_INFO_OFFSET) | \ > - BIT(IIO_CHAN_INFO_SCALE), \ > - .info_mask_shared_by_type_available = \ > - BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO), \ > - .info_mask_separate_available = \ > - BIT(IIO_CHAN_INFO_SCALE), \ > - .scan_type = { \ > - .sign = 's', \ > - .realbits = 24, \ > - .storagebits = 32, \ > - .endianness = IIO_BE, \ > - }, \ > } This looks like unneeded churn to me. ... > if (ret < 0) { > dev_warn(&adc->spi->dev, > - "failed to get conversion data\n"); > + "failed to get conversion data\n"); > goto out; > } Same as above with temporary variable for struct device. -- With Best Regards, Andy Shevchenko