From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE058C001B0 for ; Tue, 15 Aug 2023 07:20:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231244AbjHOHTk (ORCPT ); Tue, 15 Aug 2023 03:19:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234634AbjHOHS7 (ORCPT ); Tue, 15 Aug 2023 03:18:59 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CE66106; Tue, 15 Aug 2023 00:18:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692083938; x=1723619938; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7A9zUtNY8TYGnryTMNNJIGQt/lVLXvC5tdkl1W8egoA=; b=lVNnbF0S2G3mqOElDV0ZIpM08tWDWZv6HS6MjMrv2uL+sDfTRElEfoz6 nAzVej9k5JzBdlF6miHIBnJJ6Lj4FQxpt7FJA6bFc4+WHyKTrzwUtBx/Z 7wj2ccMvZxVjQhoaBsx28VFODeclZfI01qRGeizxW5Pi/0u53AYqjIRU+ 8WCMEsMD1Hr7EULkcl3EoGMYCx6ufgIdRzZxAZ7n2prRFH28g2SrBitmd Dd+NhL/7/vnccdPcJPXImltSqrRcnQDsNaDeKiGoaMaASqYBpS5/KsoQn n1RFHJSQLGFbCZJtI/GYY6M1FLK8l6Iuz8qJ/47d7Jpn1kghK3al3kYwM A==; X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="372216404" X-IronPort-AV: E=Sophos;i="6.01,174,1684825200"; d="scan'208";a="372216404" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Aug 2023 00:18:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="799106608" X-IronPort-AV: E=Sophos;i="6.01,174,1684825200"; d="scan'208";a="799106608" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 15 Aug 2023 00:18:55 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qVoKL-0084Nz-1I; Tue, 15 Aug 2023 10:18:53 +0300 Date: Tue, 15 Aug 2023 10:18:53 +0300 From: Andy Shevchenko To: Biju Das Cc: Jonathan Cameron , Lars-Peter Clausen , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Jean Delvare , Vladimir Oltean , linux-iio@vger.kernel.org, Geert Uytterhoeven , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] iio: dac: ti-dac5571: Use i2c_get_match_data() Message-ID: References: <20230812090418.75020-1-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230812090418.75020-1-biju.das.jz@bp.renesas.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sat, Aug 12, 2023 at 10:04:18AM +0100, Biju Das wrote: > Replace device_get_match_data() and id lookup for retrieving match data > by i2c_get_match_data() by converting enum->pointer for data in the > match table. ... > + {.compatible = "ti,dac5571", .data = &dac5571_spec[single_8bit] }, > + {.compatible = "ti,dac6571", .data = &dac5571_spec[single_10bit] }, > + {.compatible = "ti,dac7571", .data = &dac5571_spec[single_12bit] }, > + {.compatible = "ti,dac5574", .data = &dac5571_spec[quad_8bit] }, > + {.compatible = "ti,dac6574", .data = &dac5571_spec[quad_10bit] }, > + {.compatible = "ti,dac7574", .data = &dac5571_spec[quad_12bit] }, > + {.compatible = "ti,dac5573", .data = &dac5571_spec[quad_8bit] }, > + {.compatible = "ti,dac6573", .data = &dac5571_spec[quad_10bit] }, > + {.compatible = "ti,dac7573", .data = &dac5571_spec[quad_12bit] }, > + {.compatible = "ti,dac121c081", .data = &dac5571_spec[single_12bit] }, I would reorder them a bit. {.compatible = "ti,dac121c081", .data = &dac5571_spec[single_12bit] }, {.compatible = "ti,dac5571", .data = &dac5571_spec[single_8bit] }, {.compatible = "ti,dac6571", .data = &dac5571_spec[single_10bit] }, {.compatible = "ti,dac7571", .data = &dac5571_spec[single_12bit] }, {.compatible = "ti,dac5573", .data = &dac5571_spec[quad_8bit] }, {.compatible = "ti,dac6573", .data = &dac5571_spec[quad_10bit] }, {.compatible = "ti,dac7573", .data = &dac5571_spec[quad_12bit] }, {.compatible = "ti,dac5574", .data = &dac5571_spec[quad_8bit] }, {.compatible = "ti,dac6574", .data = &dac5571_spec[quad_10bit] }, {.compatible = "ti,dac7574", .data = &dac5571_spec[quad_12bit] }, Same for I2C ID table. -- With Best Regards, Andy Shevchenko