From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CE70C001B0 for ; Tue, 15 Aug 2023 16:51:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238578AbjHOQu0 (ORCPT ); Tue, 15 Aug 2023 12:50:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238594AbjHOQuZ (ORCPT ); Tue, 15 Aug 2023 12:50:25 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D51C1B5; Tue, 15 Aug 2023 09:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692118224; x=1723654224; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=xdukeKdTluwoMnyduKt+1RgIaLQYrs1HJOdTlBpzsAs=; b=TTEMmx5e9Q9LNvipGFTwX66qqeSZ2HiwmkzFQqiY+Sa5BgiZmyKf/fkJ 8FlVCs6vgTjCY97kuRbZBcYRzqMcZr4/vIsyaMI2aQ+DkYqngC8Y5D4ju oz1Os/Zj4buG8HxftJrp5E8WzcZ6esmyUV+JPQsSvY+j/+dDcT0qCcufF XSjCm10aif2N20y1I9rhRSjf7auFf2/c3mu0iVpvYVuuqeZGzLccxG651 AMKrDLHb0Hkgt6YkzzgfNaOKGqd4FMglcuYiCZ4+qTml56A4LlDj+tsU8 RNWt3IB7pf/8DqMTPAR1VfmdOD57KKrVyosGEq6lwT70ZtBZ0k629qq0g g==; X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="436217514" X-IronPort-AV: E=Sophos;i="6.01,175,1684825200"; d="scan'208";a="436217514" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Aug 2023 09:50:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="727423065" X-IronPort-AV: E=Sophos;i="6.01,175,1684825200"; d="scan'208";a="727423065" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 15 Aug 2023 09:50:20 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qVxFK-00A7aM-1E; Tue, 15 Aug 2023 19:50:18 +0300 Date: Tue, 15 Aug 2023 19:50:18 +0300 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Biju Das , Jonathan Cameron , Lars-Peter Clausen , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Jean Delvare , Vladimir Oltean , linux-iio@vger.kernel.org, Geert Uytterhoeven , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] iio: dac: ti-dac5571: Use i2c_get_match_data() Message-ID: References: <20230812090418.75020-1-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, Aug 15, 2023 at 09:29:06AM +0200, Geert Uytterhoeven wrote: > On Tue, Aug 15, 2023 at 9:19 AM Andy Shevchenko > wrote: > > On Sat, Aug 12, 2023 at 10:04:18AM +0100, Biju Das wrote: > > > Replace device_get_match_data() and id lookup for retrieving match data > > > by i2c_get_match_data() by converting enum->pointer for data in the > > > match table. ... > > > + {.compatible = "ti,dac5571", .data = &dac5571_spec[single_8bit] }, > > > + {.compatible = "ti,dac6571", .data = &dac5571_spec[single_10bit] }, > > > + {.compatible = "ti,dac7571", .data = &dac5571_spec[single_12bit] }, > > > + {.compatible = "ti,dac5574", .data = &dac5571_spec[quad_8bit] }, > > > + {.compatible = "ti,dac6574", .data = &dac5571_spec[quad_10bit] }, > > > + {.compatible = "ti,dac7574", .data = &dac5571_spec[quad_12bit] }, > > > + {.compatible = "ti,dac5573", .data = &dac5571_spec[quad_8bit] }, > > > + {.compatible = "ti,dac6573", .data = &dac5571_spec[quad_10bit] }, > > > + {.compatible = "ti,dac7573", .data = &dac5571_spec[quad_12bit] }, > > > + {.compatible = "ti,dac121c081", .data = &dac5571_spec[single_12bit] }, > > > > I would reorder them a bit. > > Which is safe in this particular case... > But not in general, as there might be fall-back compatible values. You mean the OF ID list must be specifically ordered?! What a nice minefield! This has to be fixed somewhere else, surely. -- With Best Regards, Andy Shevchenko