From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Philipp Jungkamp <p.jungkamp@gmx.net>,
Peter Zijlstra <peterz@infradead.org>,
linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, Jiri Kosina <jikos@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v1 2/3] iio: imu: st_lsm6dsx: Use aligned data type for timestamp
Date: Tue, 29 Aug 2023 16:18:42 +0300 [thread overview]
Message-ID: <ZO3wMlze3HRkkoMY@smile.fi.intel.com> (raw)
In-Reply-To: <20230828170341.3a9641f0@jic23-huawei>
On Mon, Aug 28, 2023 at 05:03:41PM +0100, Jonathan Cameron wrote:
> On Tue, 15 Aug 2023 18:40:26 +0300
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
...
> > struct {
> > __le16 channels[3];
> > - s64 ts __aligned(8);
> > + __aligned_s64 ts;
>
> aligned_s64 as it's internal to the kernel?
Either works, but strictly speaking you are right, better no underscored
variant.
> > } scan[ST_LSM6DSX_ID_MAX];
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-29 13:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 15:40 [PATCH v1 1/3] types: Complement the aligned types with signed 64-bit one Andy Shevchenko
2023-08-15 15:40 ` [PATCH v1 2/3] iio: imu: st_lsm6dsx: Use aligned data type for timestamp Andy Shevchenko
2023-08-28 16:03 ` Jonathan Cameron
2023-08-29 13:18 ` Andy Shevchenko [this message]
2023-08-15 15:40 ` [PATCH v1 3/3] iio: hid-sensor: " Andy Shevchenko
2023-08-28 16:09 ` Jonathan Cameron
2023-08-29 13:22 ` Andy Shevchenko
2023-08-28 16:10 ` [PATCH v1 1/3] types: Complement the aligned types with signed 64-bit one Jonathan Cameron
2023-08-29 13:22 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO3wMlze3HRkkoMY@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=p.jungkamp@gmx.net \
--cc=peterz@infradead.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox