From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9FF8C71153 for ; Mon, 4 Sep 2023 19:35:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231376AbjIDTfR (ORCPT ); Mon, 4 Sep 2023 15:35:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229967AbjIDTfR (ORCPT ); Mon, 4 Sep 2023 15:35:17 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C9ED172E; Mon, 4 Sep 2023 12:34:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 87105CE0FBF; Mon, 4 Sep 2023 19:34:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C58D5C433C9; Mon, 4 Sep 2023 19:34:45 +0000 (UTC) Date: Mon, 4 Sep 2023 15:34:43 -0400 From: William Breathitt Gray To: Fabrice Gasnier Cc: lee@kernel.org, alexandre.torgue@foss.st.com, linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/8] counter: stm32-timer-cnt: rename quadrature signal Message-ID: References: <20230829134029.2402868-1-fabrice.gasnier@foss.st.com> <20230829134029.2402868-6-fabrice.gasnier@foss.st.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NMsfRSzMtjBFjRBJ" Content-Disposition: inline In-Reply-To: <20230829134029.2402868-6-fabrice.gasnier@foss.st.com> Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org --NMsfRSzMtjBFjRBJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 29, 2023 at 03:40:26PM +0200, Fabrice Gasnier wrote: > Rename "Channel 1 Quadrature B", as it corresponds to timer input ch2. > I suspect it referred to the (unique) counter earlier, but the physical > input really is CH2. >=20 > Signed-off-by: Fabrice Gasnier > --- > drivers/counter/stm32-timer-cnt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/counter/stm32-timer-cnt.c b/drivers/counter/stm32-ti= mer-cnt.c > index 6206d2dc3d47..eae851f6db2c 100644 > --- a/drivers/counter/stm32-timer-cnt.c > +++ b/drivers/counter/stm32-timer-cnt.c > @@ -283,7 +283,7 @@ static struct counter_signal stm32_signals[] =3D { > }, > { > .id =3D 1, > - .name =3D "Channel 1 Quadrature B" > + .name =3D "Channel 2 Quadrature B" > } > }; > =20 > --=20 > 2.25.1 >=20 If these signals are going to be named after their channels, then I prefer we just remove the "Quadrature A" and "Quadrature B" conventions and leave the signals named "Channel 1" and "Channel 2" respectively. William Breathitt Gray --NMsfRSzMtjBFjRBJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZPYxUwAKCRC1SFbKvhIj KwlZAQC5qqbW6yuzMVoOIa81HPFtxG55puiquwVLPEVVevubkgD/WDPQp5tCGI/7 SRz862UcpUqXwnje45wjxncgmbRXLgQ= =+OS/ -----END PGP SIGNATURE----- --NMsfRSzMtjBFjRBJ--