From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tomas Melin <tomas.melin@vaisala.com>
Cc: linux-iio@vger.kernel.org, jic23@kernel.org, lars@metafoo.de,
u.kleine-koenig@pengutronix.de
Subject: Re: [PATCH] iio: adc: ti-ads1015: support deferred probe
Date: Tue, 5 Sep 2023 13:45:37 +0300 [thread overview]
Message-ID: <ZPcG0fzoMU5OMave@smile.fi.intel.com> (raw)
In-Reply-To: <e12f3459-7025-89a1-704b-209391cb8f55@vaisala.com>
On Tue, Sep 05, 2023 at 09:13:28AM +0300, Tomas Melin wrote:
> On 04/09/2023 14:23, Andy Shevchenko wrote:
> > On Mon, Sep 04, 2023 at 01:15:22PM +0300, Tomas Melin wrote:
...
> >> +out:
> >> + if ((ret == -EAGAIN) || (ret == -ENXIO))
> >> + return -EPROBE_DEFER;
> >> + return ret;
> >
> > Oh my... This looks so-o hackish.> If anything, it has to be fixed on the level of regmap I2C APIs or
> so.As such this does fix a real world issue. Providing some helpers for
> this on regmap level would probably be great. To add such an API I
> suspect there should first be existing users for it, and this would be
> one example.
> Until there would be such an generic API, I'm not sure if there are many
> other alternatives than to check for invalid returns and defer the probe.
As Jonathan said, please try to elaborate better what the real word issue is,
how it can be reproduced, etc.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-05 16:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 10:15 [PATCH] iio: adc: ti-ads1015: support deferred probe Tomas Melin
2023-09-04 11:23 ` Andy Shevchenko
2023-09-04 13:12 ` Jonathan Cameron
2023-09-05 11:43 ` Tomas Melin
2023-09-05 12:31 ` Lars-Peter Clausen
2023-09-06 5:59 ` Tomas Melin
2023-09-05 12:38 ` Andy Shevchenko
2023-09-05 6:13 ` Tomas Melin
2023-09-05 10:45 ` Andy Shevchenko [this message]
2023-09-05 11:44 ` Tomas Melin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPcG0fzoMU5OMave@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=tomas.melin@vaisala.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox