From: Raag Jadav <raag.jadav@intel.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: rafael@kernel.org, len.brown@intel.com, pavel@ucw.cz,
Jonathan.Cameron@huawei.com, andriy.shevchenko@linux.intel.com,
lars@metafoo.de, rmfrfs@gmail.com,
jean-baptiste.maneyrol@tdk.com, lee@kernel.org,
laurentiu.palcu@oss.nxp.com, l.stach@pengutronix.de,
james.schulman@cirrus.com, david.rhodes@cirrus.com,
rf@opensource.cirrus.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
dri-devel@lists.freedesktop.org, patches@opensource.cirrus.com,
mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com
Subject: Re: [PATCH for-next v2 02/10] PM: Update EXPORT_*_DEV_PM_OPS() to EXPORT_*_RUNTIME_PM_OPS()
Date: Mon, 18 Sep 2023 11:55:38 +0300 [thread overview]
Message-ID: <ZQgQilY20yEUPtt3@black.fi.intel.com> (raw)
In-Reply-To: <a31817a460f8ee66c9d460e97aeea62b2bcfbc51.camel@crapouillou.net>
On Mon, Sep 18, 2023 at 10:20:29AM +0200, Paul Cercueil wrote:
> Le lundi 18 septembre 2023 à 13:39 +0530, Raag Jadav a écrit :
> > Rename EXPORT_*_DEV_PM_OPS() macros to EXPORT_*_RUNTIME_PM_OPS()
> > and while at it, move them to pm_runtime.h.
> > This is done in conjunction with the introduction of
> > EXPORT_*_SIMPLE_PM_OPS() set of macros, to make things less
> > confusing.
> > This makes both _RUNTIME_ and _SIMPLE_ variants of export macros more
> > distinguishable and self explanatory.
>
> Well I don't really agree with this one. The EXPORT_*_DEV_PM_OPS() can
> be used with any callback you need, not just the typical runtime-PM
> callbacks. They are generic PM macros.
I agree on the usage part. But with the introduction of export macros for
_SIMPLE_ variants, current naming scheme would make things unnecessarily
confusing to the users in my opinion.
Perhaps we can have it simplified some other way?
Raag
next prev parent reply other threads:[~2023-09-18 8:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 8:09 [PATCH for-next v2 00/10] Fix symbol export for _SIMPLE_ variants of _PM_OPS() Raag Jadav
2023-09-18 8:09 ` [PATCH for-next v2 01/10] PM: Introduce export macros " Raag Jadav
2023-09-18 8:09 ` [PATCH for-next v2 02/10] PM: Update EXPORT_*_DEV_PM_OPS() to EXPORT_*_RUNTIME_PM_OPS() Raag Jadav
2023-09-18 8:20 ` Paul Cercueil
2023-09-18 8:55 ` Raag Jadav [this message]
2023-09-18 8:09 ` [PATCH for-next v2 03/10] iio: accel: fxls8962af: convert to EXPORT_NS_GPL_RUNTIME_PM_OPS() Raag Jadav
2023-09-18 9:40 ` Richard Fitzgerald
2023-09-18 8:09 ` [PATCH for-next v2 04/10] iio: gyro: fxas21002c: " Raag Jadav
2023-09-18 8:09 ` [PATCH for-next v2 05/10] iio: imu: inv_icm42600: " Raag Jadav
2023-09-18 8:09 ` [PATCH for-next v2 06/10] iio: imu: inv_mpu: " Raag Jadav
2023-09-18 8:09 ` [PATCH for-next v2 07/10] drm/imx/dcss: convert to EXPORT_GPL_RUNTIME_PM_OPS() Raag Jadav
2023-09-18 8:09 ` [PATCH for-next v2 08/10] mfd: arizona: " Raag Jadav
2023-09-18 8:09 ` [PATCH for-next v2 09/10] mfd: cs42l43: convert to EXPORT_NS_GPL_RUNTIME_PM_OPS() Raag Jadav
2023-09-18 8:09 ` [PATCH for-next v2 10/10] ASoC: cs35l41: convert to EXPORT_GPL_RUNTIME_PM_OPS() Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQgQilY20yEUPtt3@black.fi.intel.com \
--to=raag.jadav@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bala.senthil@intel.com \
--cc=david.rhodes@cirrus.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=james.schulman@cirrus.com \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=l.stach@pengutronix.de \
--cc=lars@metafoo.de \
--cc=laurentiu.palcu@oss.nxp.com \
--cc=lee@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=patches@opensource.cirrus.com \
--cc=paul@crapouillou.net \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=rf@opensource.cirrus.com \
--cc=rmfrfs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox