From: Tzung-Bi Shih <tzungbi@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
linux-iio@vger.kernel.org, chrome-platform@lists.linux.dev,
kernel@pengutronix.de
Subject: Re: [PATCH 45/49] iio: proximity: cros_ec_mkbp: Convert to platform remove callback returning void
Date: Wed, 20 Sep 2023 15:45:25 +0800 [thread overview]
Message-ID: <ZQqjFWBPti2c734w@google.com> (raw)
In-Reply-To: <20230919174931.1417681-46-u.kleine-koenig@pengutronix.de>
On Tue, Sep 19, 2023 at 07:49:27PM +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
next prev parent reply other threads:[~2023-09-20 7:46 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 17:48 [PATCH 00/49] iio: Convert to platform remove callback returning void Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 01/49] iio: accel: hid-sensor-accel-3d: " Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 02/49] iio: adc: ab8500-gpadc: " Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 03/49] iio: adc: at91-sama5d2: " Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 04/49] iio: adc: at91: " Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 05/49] iio: adc: axp20x: " Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 06/49] iio: adc: bcm_iproc: " Uwe Kleine-König
2023-09-19 18:54 ` Florian Fainelli
2023-09-19 17:48 ` [PATCH 07/49] iio: adc: dln2: " Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 08/49] iio: adc: ep93xx: " Uwe Kleine-König
2023-09-19 17:54 ` Alexander Sverdlin
2023-09-19 17:48 ` [PATCH 09/49] iio: adc: exynos: " Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 10/49] iio: adc: fsl-imx25-gcq: " Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 11/49] iio: adc: hx711: " Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 12/49] iio: adc: imx8qxp: " Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 13/49] iio: adc: imx93: " Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 14/49] iio: adc: meson_saradc: " Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 15/49] iio: adc: mp2629: " Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 16/49] iio: adc: mxs-lradc: " Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 17/49] iio: adc: npcm: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 18/49] iio: adc: qcom-pm8xxx-xoadc: " Uwe Kleine-König
2023-09-19 21:14 ` Konrad Dybcio
2023-09-19 17:49 ` [PATCH 19/49] iio: adc: rcar-gyroadc: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 20/49] iio: adc: stm32-adc-core: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 21/49] iio: adc: stm32-adc: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 22/49] iio: adc: stm32-dfsdm-adc: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 23/49] iio: adc: stm32-dfsdm-core: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 24/49] iio: adc: sun4i-gpadc-iio: " Uwe Kleine-König
2023-09-19 17:58 ` Jernej Škrabec
2023-09-19 17:49 ` [PATCH 25/49] iio: adc: ti_am335x_adc: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 26/49] iio: adc: twl4030-madc: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 27/49] iio: adc: twl6030-gpadc: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 28/49] iio: adc: vf610_adc: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 29/49] iio: dac: dpot-dac: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 30/49] iio: dac: lpc18xx_dac: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 31/49] iio: dac: stm32-dac-core: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 32/49] iio: dac: stm32-dac: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 33/49] iio: dac: vf610: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 34/49] iio: gyro: hid-sensor-gyro-3d: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 35/49] iio: humidity: hid-sensor-humidity: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 36/49] iio: light: cm3605: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 37/49] iio: light: hid-sensor-als: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 38/49] iio: light: hid-sensor-prox: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 39/49] iio: light: lm3533-als: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 40/49] iio: magnetometer: hid-sensor-magn-3d: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 41/49] iio: orientation: hid-sensor-incl-3d: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 42/49] iio: orientation: hid-sensor-rotation: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 43/49] iio: position: hid-sensor-custom-intel-hinge: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 44/49] iio: pressure: hid-sensor: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 45/49] iio: proximity: cros_ec_mkbp: " Uwe Kleine-König
2023-09-20 7:45 ` Tzung-Bi Shih [this message]
2023-09-19 17:49 ` [PATCH 46/49] iio: proximity: srf04: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 47/49] iio: temperature: hid-sensor: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 48/49] iio: trigger: iio-trig-interrupt: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 49/49] iio: trigger: stm32-timer: " Uwe Kleine-König
2023-09-23 17:35 ` [PATCH 00/49] iio: " Jonathan Cameron
2023-11-13 3:23 ` patchwork-bot+chrome-platform
2023-11-13 3:42 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQqjFWBPti2c734w@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).