From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5514DC4332F for ; Mon, 6 Nov 2023 10:22:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229841AbjKFKWZ (ORCPT ); Mon, 6 Nov 2023 05:22:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229715AbjKFKWY (ORCPT ); Mon, 6 Nov 2023 05:22:24 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C650FA9; Mon, 6 Nov 2023 02:22:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699266141; x=1730802141; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=JP77JuXadXlcyyGj4/V5z2uuMm7pBizXqmlsL1zSEBk=; b=WcodCoSLLooXOcsthiyTeEUziCCO3w810MxniKimR+4KnIuGbe7FLlbw IJY4vp/jAfOdyxvhpVlZTsC9wabEh1nmECXTytLmTbzv7fHTicgkMRDvK CvCbR1mqMlr5wKdnhu9CEsHLMNyUZCW7D9Q3W8tcQgyL4VGkl1pP4r4ar 70UBe5KmMud/pnT+/P7XWxspm+bjNAilxLLqCYpuPoWrHH1b5pftWTrge BA8u79F7tvL305K7aH/HIp0W5O+15VHlSBZxER5GR8+xSKkzrcl+EOaH0 HBWhpXzPo2E1p/Pdtum+P3GcLBjghmCW7aQNhZH9e6zY+9po2B5bu/zqk Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10885"; a="2235015" X-IronPort-AV: E=Sophos;i="6.03,281,1694761200"; d="scan'208";a="2235015" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2023 02:22:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10885"; a="935755023" X-IronPort-AV: E=Sophos;i="6.03,281,1694761200"; d="scan'208";a="935755023" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2023 02:22:15 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC3) (envelope-from ) id 1qzwkG-0000000BlCT-0ZNB; Mon, 06 Nov 2023 12:22:12 +0200 Date: Mon, 6 Nov 2023 12:22:11 +0200 From: Andy Shevchenko To: alisadariana@gmail.com Cc: Alisa-Dariana Roman , Alexandru Tachici , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maksim Kiselev , Cosmin Tanislav , Arnd Bergmann , Liam Beguin , Marius Cristea , Ibrahim Tilki , ChiaEn Wu , Ivan Mikhaylov , Marcus Folkesson , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] iio: adc: ad7192: Use device api Message-ID: References: <20231105193132.47009-1-alisadariana@gmail.com> <20231105193132.47009-2-alisadariana@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231105193132.47009-2-alisadariana@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sun, Nov 05, 2023 at 09:31:29PM +0200, alisadariana@gmail.com wrote: > From: Alisa-Dariana Roman > > Replace of.h and corresponding functions with preferred device specific > functions. > > Also replace of_device_get_match_data function with of_device_get_match_data() > spi_get_device_match_data. spi_get_device_match_data() With the above fixed, Reviewed-by: Andy Shevchenko The first patch should be documentation of the properties as Krzysztof noted. P.S. Also consider using or taking an ideas from the "smart" script [1] I wrote to send patches, it will put the better list of people into the proper places, including maintainers and mailing lists. [1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh -- With Best Regards, Andy Shevchenko