From: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
To: Brajesh Patil <brajeshpatil11@gmail.com>
Cc: linux-iio@vger.kernel.org, jic23@kernel.org, lars@metafoo.de,
linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Subject: Re: [PATCH v1 1/1] iio: dummy: Add 3-axis compass (magnetometer) channels to the iio_simple_dummy
Date: Sun, 6 Apr 2025 14:42:32 -0300 [thread overview]
Message-ID: <Z_K9CFItAcYS8r4a@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <20250406133349.50633-1-brajeshpatil11@gmail.com>
Hi Brajesh,
On 04/06, Brajesh Patil wrote:
> This patch adds support for 3-axis magnetometer data (X, Y, Z) in the
> iio_simple_dummy driver. It introduces three new IIO_MAGN channels and
> populates them with dummy values for testing and prototyping purposes.
>
> Signed-off-by: Brajesh Patil <brajeshpatil11@gmail.com>
> ---
> drivers/iio/dummy/iio_simple_dummy.c | 71 +++++++++++++++++++++++++++-
> drivers/iio/dummy/iio_simple_dummy.h | 6 +++
> 2 files changed, 75 insertions(+), 2 deletions(-)
>
I'm pretty sure the changes introduced in the IIO dummy tutorial [1] were
for learning purposes only and not intended for upstreaming.
I don't see a reason for updating the upstream dummy driver with those.
It would also make the tutorial less interesting.
[1]: https://flusp.ime.usp.br/iio/experiment-one-iio-dummy/
So NACK for this patch.
Regards,
Marcelo
prev parent reply other threads:[~2025-04-06 17:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-06 13:33 [PATCH v1 1/1] iio: dummy: Add 3-axis compass (magnetometer) channels to the iio_simple_dummy Brajesh Patil
2025-04-06 13:41 ` Julia Lawall
2025-04-06 15:39 ` Jonathan Cameron
2025-04-06 17:42 ` Marcelo Schmitt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_K9CFItAcYS8r4a@debian-BULLSEYE-live-builder-AMD64 \
--to=marcelo.schmitt1@gmail.com \
--cc=brajeshpatil11@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox