From: Petre Rodan <petre.rodan@subdimension.ro>
To: andy.shevchenko@gmail.com
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v2 4/4] iio: pressure: hsc030pa add triggered buffer
Date: Mon, 5 Feb 2024 18:39:02 +0200 [thread overview]
Message-ID: <ZcEPJh1i7cc0xyBW@sunspire> (raw)
In-Reply-To: <Zb-1UGJt27OV-vjc@surfacebook.localdomain>
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
hello Andy,
On Sun, Feb 04, 2024 at 06:03:28PM +0200, andy.shevchenko@gmail.com wrote:
[..]
> > + memcpy(&data->scan.chan[1], &data->buffer[2], 2);
>
> Hmm... We don't have fixed-size memcpy() :-(
__be16 *ptr;
ptr = (__be16 *) data->buffer;
data->scan.chan[0] = *ptr;
data->scan.chan[1] = *++ptr;
is this an acceptable replacement? I do not understand that your concern was, my
intent was to copy exactly 2 bytes over.
> > + iio_push_to_buffers_with_timestamp(indio_dev, &data->scan,
> > + iio_get_time_ns(indio_dev));
thanks,
peter
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-02-05 16:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-27 16:03 [PATCH v2 0/4] iio: pressure: hsc030pa: cleanup and triggered buffer Petre Rodan
2024-01-27 16:03 ` [PATCH v2 1/4] dt-bindings: iio: pressure: honeywell,hsc030pa.yaml add spi props Petre Rodan
2024-01-29 8:23 ` Krzysztof Kozlowski
2024-01-27 16:03 ` [PATCH v2 2/4] iio: pressure: hsc030pa cleanup Petre Rodan
2024-01-27 16:57 ` Jonathan Cameron
2024-01-27 16:03 ` [PATCH v2 3/4] iio: pressure: hsc030pa add mandatory delay Petre Rodan
2024-01-27 16:03 ` [PATCH v2 4/4] iio: pressure: hsc030pa add triggered buffer Petre Rodan
2024-01-27 16:59 ` Jonathan Cameron
2024-02-04 13:44 ` Jonathan Cameron
2024-02-04 16:10 ` Jonathan Cameron
2024-02-04 16:03 ` andy.shevchenko
2024-02-05 16:39 ` Petre Rodan [this message]
2024-02-10 15:09 ` Jonathan Cameron
2024-02-10 15:12 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcEPJh1i7cc0xyBW@sunspire \
--to=petre.rodan@subdimension.ro \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox