From: William Breathitt Gray <william.gray@linaro.org>
To: Nuno Sa <nuno.sa@analog.com>
Cc: linux-iio@vger.kernel.org,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2] counter: fix privdata alignment
Date: Fri, 16 Feb 2024 18:41:02 -0500 [thread overview]
Message-ID: <Zc_yjo0A3KO0EoU0@ishi> (raw)
In-Reply-To: <20240209-counter-align-fix-v2-1-5777ea0a2722@analog.com>
[-- Attachment #1: Type: text/plain, Size: 761 bytes --]
On Fri, Feb 09, 2024 at 04:50:34PM +0100, Nuno Sa wrote:
> Aligning to the L1 cache does not guarantee the same alignment as
> kmallocing an object [1]. Furthermore, in some platforms, that
> alignment is not sufficient for DMA safety (in case someone wants
> to have a DMA safe buffer in privdata) [2].
>
> Sometime ago, we had the same fixes in IIO.
>
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/base/devres.c#n35
> [2]: https://lore.kernel.org/linux-iio/20220508175712.647246-2-jic23@kernel.org/
>
> Fixes: c18e2760308e ("counter: Provide alternative counter registration functions")
> Signed-off-by: Nuno Sa <nuno.sa@analog.com>
Applied as commit b6dce0452a02, thanks!
William Breathitt Gray
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2024-02-16 23:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 15:50 [PATCH v2] counter: fix privdata alignment Nuno Sa
2024-02-16 23:41 ` William Breathitt Gray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zc_yjo0A3KO0EoU0@ishi \
--to=william.gray@linaro.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox