From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 793DA31A7E for ; Mon, 19 Feb 2024 11:59:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708343985; cv=none; b=QEyyDDVzh4aO+7yukUcpEn8cZNxl+qWSxMRA/EUMCdvLxCQWO+2Vw28PzsfHNr0vT9EXd7pSw0Sx8nsByLYgT7KPH7zTe+j+Q+mpjAJJVgCJGihvHYPZdhIP8ByABu3F05heowh4dHQ8co09Fvj+iaRV67BS5f1CT7iuMUUP194= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708343985; c=relaxed/simple; bh=54YSOaq1BNIOLytkRgBMTG7M88cY7cH+LztNCeg+7Uc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rwRBpyA5a1ChGBVU4gGNGlHe6PGpS6UBve/j9Z9jUgOTN4OvcjyxgoKGTU8vfEqmSoboBl2BiYVadZbkjb2gOn4/xNiIuZVj3xGsrwoqu7ThsdOhfYI4zKFLPkMvwl19M/Y6g8yU+ioR7nQw+loaYldPh1q39h/8Rvc3gJfxsqE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=J6diq3ed; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="J6diq3ed" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708343984; x=1739879984; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=54YSOaq1BNIOLytkRgBMTG7M88cY7cH+LztNCeg+7Uc=; b=J6diq3ed7KGtm24dTIdPKore33c1CRRyv/NKV9dFbyn3TKRG1jR/mmNi AU3t8JhyPq5IoHC3Y4ZWsecLMXkMR0jn/kFHyUJ/tOGAJhFmE2E1jv2m9 ly0UcQwQ2wHtfIJxJGMtxuSY+ExOP5B4v06wAYjfM2X88RH6uQapG8A84 N1rE9FMLOSyCjbKD4g9/pB2qLEH7U/eXDcwMS4UB5XQkwwgIdsMJUvh9+ FshyIz+Byg3bLEo/VAqhfJdKqoyw/OYGf+Aplw7SfIfGh3GpNnQyUjo4+ CaFPj/5k6hTxhXSeX2yrGxt1jfkWPn0z/tqKVlipffY6BeJ+jtHuFCMA4 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10988"; a="19951330" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="19951330" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 03:59:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10988"; a="912863165" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="912863165" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 03:59:39 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rc2J6-00000005oTQ-24Yn; Mon, 19 Feb 2024 13:59:36 +0200 Date: Mon, 19 Feb 2024 13:59:36 +0200 From: Andy Shevchenko To: Nuno =?iso-8859-1?Q?S=E1?= Cc: Jonathan Cameron , linux-iio@vger.kernel.org, Lars-Peter Clausen , Michael Hennerich , Nuno =?iso-8859-1?Q?S=E1?= , Alisa-Dariana Roman , Haibo Chen , Sean Nyekjaer , Andreas Klinger , Jonathan Cameron Subject: Re: [PATCH 3/8] iio: adc: ad7124: Switch from of specific to fwnode based property handling Message-ID: References: <20240218172731.1023367-1-jic23@kernel.org> <20240218172731.1023367-4-jic23@kernel.org> <7f4f569b9e8edd017f92d1fb583bdbe419fe4e87.camel@gmail.com> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7f4f569b9e8edd017f92d1fb583bdbe419fe4e87.camel@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Feb 19, 2024 at 10:24:59AM +0100, Nuno Sá wrote: > On Sun, 2024-02-18 at 17:27 +0000, Jonathan Cameron wrote: ... > > + cfg->buf_positive = > > + fwnode_property_read_bool(child, "adi,buffered- > > positive"); > > + cfg->buf_negative = > > + fwnode_property_read_bool(child, "adi,buffered- > > negative"); > > I think this is one of those cases where 80col limit hurts readability... I like long lines, but to be honest this is also usual pattern on how to split long lines. I leave this to you, folks, to solve :-) -- With Best Regards, Andy Shevchenko