From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7FE031A89 for ; Mon, 19 Feb 2024 12:02:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708344159; cv=none; b=I1feW2HuNQRqSGUA5s8DVlGXeQvbyIbLYrKJFiLUisdXW0pda9+p8gGLn6Ml4OSfCs5c3/rWQoTdJcveGRlPfuSW+gN2wQbK4yaAJngpd/RKZsEuxmepxcx0vXWRr/pu4Lf6MZoSILCAVlrscGtM2RuKBRnDfrFnnW8yMFlYCdw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708344159; c=relaxed/simple; bh=cJ069myId/c0BZ22/hI/m+pk4xah8bBedCmukIaWpVQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lio0gOObA9ZhHYq38G9gpukHK8WHzKrs388QB+1AR3X+BsP8sxu6IDTKD2KmtEK689bqGjvBHgbQhGm4IegLRBizXMZPiuqWOWQzgV3emjeafPG00tz+KA4+iQsOOF6HxIVygXp2dbF59pNUzHzts9M4ssLHPk0PZFoU4jsYv80= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=QJnKDyjO; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="QJnKDyjO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708344158; x=1739880158; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=cJ069myId/c0BZ22/hI/m+pk4xah8bBedCmukIaWpVQ=; b=QJnKDyjOdWRYGvXZcqs5OklUe9NLvsdvXnF5fAAFBO8dudMkEjK48Nne RwhZ18sWbT0nbcvdUrtWtz9UBXwDnnuFJEQK+2nAseqgWlhMbZP+aNxD/ H5afQFqW1tmyeilIG5XOUTCNaAnvL6GTd2wM+ky8SuRa2M0UiqvJIeTr9 cCxCE3jWIk0368bEj76qVKPRcAFZtvtQTl7Zo9lXN2INdOhNlG8fafrlQ xgwIng8p8aD14OTh/bgeevrQR7H6girEgGfk1L87FdD86JLtRplk9V+UB m6x70sweFVZ6jzt/q5mQNFlHBc1BFbx0zPRgq2dPnoFTczCk8TRO6r7AE g==; X-IronPort-AV: E=McAfee;i="6600,9927,10988"; a="5380612" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="5380612" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 04:02:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10988"; a="912863744" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="912863744" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 04:02:15 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rc2Lc-00000005oVB-0zZw; Mon, 19 Feb 2024 14:02:12 +0200 Date: Mon, 19 Feb 2024 14:02:11 +0200 From: Andy Shevchenko To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, Lars-Peter Clausen , Michael Hennerich , Nuno =?iso-8859-1?Q?S=E1?= , Alisa-Dariana Roman , Haibo Chen , Sean Nyekjaer , Andreas Klinger , Jonathan Cameron Subject: Re: [PATCH 5/8] iio: adc: ad7192: Convert from of specific to fwnode property handling Message-ID: References: <20240218172731.1023367-1-jic23@kernel.org> <20240218172731.1023367-6-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240218172731.1023367-6-jic23@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Sun, Feb 18, 2024 at 05:27:28PM +0000, Jonathan Cameron wrote: > From: Jonathan Cameron > > Enables use of with other firmwware types. > Removes a case of device tree specific handlers that might get copied > into new drivers. ... > - dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X != 0x%X)\n", > + dev_warn(dev, "device ID query failed (0x%X != 0x%X)\n", > id, st->chip_info->chip_id); Now id can be moved to the previous line (but it's up to you as you may argue that this is the logical split). ... > - burnout_curr_en = of_property_read_bool(np, > - "adi,burnout-currents-enable"); > + burnout_curr_en = device_property_read_bool(dev, > + "adi,burnout-currents-enable"); Same pattern as in the other patch? burnout_curr_en = device_property_read_bool(dev, "adi,burnout-currents-enable"); -- With Best Regards, Andy Shevchenko