From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vasileios Amoiridis <vassilisamir@gmail.com>
Cc: jic23@kernel.org, lars@metafoo.de, ang.iglesiasg@gmail.com,
phil@raspberrypi.com, 579lpy@gmail.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: pressure: Fixes SPI support for BMP3xx devices
Date: Mon, 11 Mar 2024 12:05:07 +0200 [thread overview]
Message-ID: <Ze7XU5JS8FF5FZdg@smile.fi.intel.com> (raw)
In-Reply-To: <20240311005432.1752853-1-vassilisamir@gmail.com>
On Mon, Mar 11, 2024 at 01:54:32AM +0100, Vasileios Amoiridis wrote:
> Bosch does not use unique BMPxxx_CHIP_ID for the different versions of
> the device which leads to misidentification of devices if their ID is
> used. Use a new value in the chip_info structure instead of the
> BMPxxx_CHIP_ID, in order to choose the regmap_bus to be used.
...
> const struct regmap_config *regmap_config;
> + int spi_read_extra_byte;
Why is it int and not boolean?
Also, please run `pahole` to see the best place for a new member.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-03-11 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 0:54 [PATCH] iio: pressure: Fixes SPI support for BMP3xx devices Vasileios Amoiridis
2024-03-11 10:05 ` Andy Shevchenko [this message]
2024-03-11 15:58 ` Jonathan Cameron
2024-03-11 16:44 ` Vasileios Amoiridis
2024-03-14 14:27 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ze7XU5JS8FF5FZdg@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=579lpy@gmail.com \
--cc=ang.iglesiasg@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phil@raspberrypi.com \
--cc=vassilisamir@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox