RE: [PATCH v3 5/7] dt-bindings: iio: pressure: bmp085: Add interrupts for BMP3xx and BMP5xx devices

Biju Das
2024-08-23T18:52:01Z

Hi Vasileios Amoiridis,

Thanks for the patch.

> -----Original Message-----
> From: Vasileios Amoiridis <vassilisamir@gmail.com>
> Sent: Friday, August 23, 2024 7:17 PM
> Subject: [PATCH v3 5/7] dt-bindings: iio: pressure: bmp085: Add interrupts for BMP3xx and BMP5xx
> devices
>
> Add interrupt options for BMP3xx and BMP5xx devices as well.
>
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> ---
> Documentation/devicetree/bindings/iio/pressure/bmp085.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> index 6fda887ee9d4..eb1e1ab3dd18 100644
> --- a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> +++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> @@ -48,9 +48,14 @@ properties:
>
> interrupts:
> description:
> - interrupt mapping for IRQ (BMP085 only)
> + interrupt mapping for IRQ. Supported in BMP085, BMP3xx, BMP5xx

Since you have updated the description. It is better to enforce the same in
conditional schema?? So that dt binding check throws error if interrupt
used in bmp{180,280 and bme280}.

Cheers,
Biju

> maxItems: 1
>
> + drive-open-drain:
> + description:
> + set if the interrupt pin should be configured as open drain.
> + If not set, defaults to push-pull configuration.
> +
> required:
> - compatible
> - vddd-supply
> --
> 2.25.1