From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Gyeyoung Baek <gye976@gmail.com>
Cc: jic23@kernel.org, lars@metafoo.de,
jean-baptiste.maneyrol@tdk.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: imu: inv_mpu6050: Remove duplicate code between labels
Date: Wed, 4 Sep 2024 02:28:16 +0300 [thread overview]
Message-ID: <ZtebkIvceS5x9_ib@surfacebook.localdomain> (raw)
In-Reply-To: <20240901120839.9274-1-gye976@gmail.com>
Sun, Sep 01, 2024 at 09:08:39PM +0900, Gyeyoung Baek kirjoitti:
> 'flush_fifo' label performs same task as 'endsession' label
> immediately after calling 'env_reset_fifo' function.
> So i remove that duplication.
...
> -end_session:
> - mutex_unlock(&st->lock);
> - iio_trigger_notify_done(indio_dev->trig);
> -
> - return IRQ_HANDLED;
You missed
goto end_session;
here.
> flush_fifo:
> /* Flush HW and SW FIFOs. */
> inv_reset_fifo(indio_dev);
> +
> +end_session:
> mutex_unlock(&st->lock);
> iio_trigger_notify_done(indio_dev->trig);
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-09-03 23:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-01 12:08 [PATCH v2] iio: imu: inv_mpu6050: Remove duplicate code between labels Gyeyoung Baek
2024-09-01 14:11 ` Jonathan Cameron
2024-09-02 1:53 ` gyeyoung
2024-09-02 9:51 ` Jean-Baptiste Maneyrol
2024-09-02 13:35 ` Markus Elfring
2024-09-03 23:28 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtebkIvceS5x9_ib@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=gye976@gmail.com \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox