From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v3 0/4] iio: initialise ddata for iio_get_acpi_device_name_and_data()
Date: Fri, 1 Nov 2024 18:42:42 +0200 [thread overview]
Message-ID: <ZyUFAjwjAWcJH8ag@smile.fi.intel.com> (raw)
In-Reply-To: <20241101145938.304fd98b@jic23-huawei>
On Fri, Nov 01, 2024 at 02:59:38PM +0000, Jonathan Cameron wrote:
> On Fri, 1 Nov 2024 15:16:00 +0200
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > Dan reported that ddata might be used uninitialised in some cases.
> > Let's initialise it to NULL (patches 1 - 3). With that, update one driver
> > to drop an unneeded anymore check (included in patch 3).
> >
> > While at it, one more cleanup to kxcjk-1013 (patch 4) is added.
> >
> > Jonathan, dunno if you want to rebase at this stage (probably not),
> > but if you do, feel free to fold the patches 1-3 to the initial code.
> Ah. I've just picked v2, but given I squashed anyway the commit message
> changes don't matter.
Thanks, I have looked into the resulting changes and it all LGTM!
> I was curious what Assing meant but not need to
> ask given I wasn't going to keep it.
He-he :-)
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-11-01 16:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 13:16 [PATCH v3 0/4] iio: initialise ddata for iio_get_acpi_device_name_and_data() Andy Shevchenko
2024-11-01 13:16 ` [PATCH v3 1/4] iio: light: isl29018: Assign NULL to ddata in isl29018_probe() Andy Shevchenko
2024-11-01 13:16 ` [PATCH v3 2/4] iio: light: ltr501: Assign NULL to ddata in ltr501_probe() Andy Shevchenko
2024-11-01 13:16 ` [PATCH v3 3/4] iio: accel: kxcjk-1013: Assign NULL to ddata in kxcjk1013_probe() Andy Shevchenko
2024-11-01 13:16 ` [PATCH v3 4/4] iio: accel: kxcjk-1013: Deduplicate ODR startup time array Andy Shevchenko
2024-11-01 14:59 ` [PATCH v3 0/4] iio: initialise ddata for iio_get_acpi_device_name_and_data() Jonathan Cameron
2024-11-01 16:42 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyUFAjwjAWcJH8ag@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox