From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54A821D5173 for ; Fri, 15 Nov 2024 17:15:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731690902; cv=none; b=jPuP7QrB38olqORQY13+5XRODPD9ls5oq2jr4j7Vju4MPSYmI6iCVLtzqqpDBs5JvamOMD1UUupkZ/6S7oqUI0hgaMWOwYGFRv/0CZEUSXJxR7mwm24R28G+MYTyN5+F75eucuXPClsv7RcdTMY9gVqw4t+thM3XMbzKR8SUcII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731690902; c=relaxed/simple; bh=MLVGdOKUHWHTbWRLhDF0MToJ/PEyDmhqvew3tWWi1Ro=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oWWNHxRgihcZYYroCbdT/OrGkfXN6xWtPoNecJoeaw4HcpgF/Oz+E7OAdK+oxiZ7pM/IZY/pnHvfT8v+b9MJKd+7xmU4+tq3Pk74X9mCZIsWRjLQrC6iImlRGsm8EDwEbG8STqAHRWpqC8eUCgpeVJmLqps4Z6kdf65YzGx93d0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=jf7YoCl1; arc=none smtp.client-ip=209.85.167.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="jf7YoCl1" Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3e7b706b966so1037649b6e.1 for ; Fri, 15 Nov 2024 09:15:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1731690899; x=1732295699; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+t5QbplXWf+OH1Spy65VnQjon5zvVtjuq4EZhXbiI6U=; b=jf7YoCl1czhp9aIYVRd2MzNKpL36C9ZX28iPoA3EgyKzI1957EqTomkM5f6wolaoGc YLzbroZxa/kd4bgZ4rjrYyCwzywk5Rfp8Dla61+daYEmbgb8XCb3TLfAqcZPHp3wq6sq rhHImRt9KPEOoqKn+FmhcjVysB829MWnErku45PtntwN7VErqfWg1iDLqR103+lYeKCJ 6RdWra6ki2RmBmd2JrXn7BPOJIE467IZmM/2lgvXHdsw92fyn/jkqM/9yoiH6u9Gum+0 /fr+kvl0iK+bJLPq+M8iimZWe1nApQYFY17dtegNBei0VO+NzvINVHhjfFOEMWfGkHmG nQ5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731690899; x=1732295699; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+t5QbplXWf+OH1Spy65VnQjon5zvVtjuq4EZhXbiI6U=; b=V/myE3WWaf+U38wkyd/X7iR26C066EYnUQfDJi5akrkoA39SmHhqnnTz36YrKSirTs FlNiNRbr9/SLHkr1myrR4fB8HcRYx/ghIpz0dhz0OkNP/dZF+1lIvMGZwUrrHuml41VK f0XGkUpbGNhf2u7jCDpHfub+sf/Bd4jqiAzZmwgUpMANayDwNpXU5/YNyk7S7RnVbhGS pfjrWsnH3MsFCqcXrzzzOXsb3LPRRvTjkcVmbCMB9GlBuGxi7SrZ1Wih/4NJaGX/B2Gy JBrrMijl6r3b+4PkkfkD+9+D1ktCW1XCYybLloQSvIS2KxjGwjFK8XAjaEah/K8J4C3t VnMA== X-Gm-Message-State: AOJu0Yzypp+wsRLBoxon5t1bcPPDMvKpuxYxKH75hjMupsaDBXOcFNUA TSkTDjM8NlK369IJss3+NvX+Et0DFK8EXVIQovS0O/OmRh1m+3xYu3hkZvHzdyg= X-Google-Smtp-Source: AGHT+IFA6j1bD6Ro4mlGCDGX37IVHQawFAOECWLhe4iMVSQfihiezYooSzpr0q3F9esVAzQwmh3qAQ== X-Received: by 2002:a05:6808:3a0a:b0:3e6:22ce:d1c4 with SMTP id 5614622812f47-3e7b66c64e1mr4790001b6e.12.1731690897961; Fri, 15 Nov 2024 09:14:57 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-71a780feccasm592983a34.28.2024.11.15.09.14.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Nov 2024 09:14:57 -0800 (PST) Message-ID: Date: Fri, 15 Nov 2024 11:14:56 -0600 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] iio: adc: ad4000: Add support for PulSAR devices To: Marcelo Schmitt , lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, marcelo.schmitt1@gmail.com Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/14/24 5:51 PM, Marcelo Schmitt wrote: > The AD4000 series and the single-channel PulSAR series of devices have > similar SPI transfer specifications and wiring configurations. > Single-channel PulSAR devices are slower than AD4000, and don't have a > configuration register. That taken into account, single-channel PulSARs can > be supported by the ad4000 driver without any increase in code complexity. > > Signed-off-by: Marcelo Schmitt > --- > drivers/iio/adc/ad4000.c | 163 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 163 insertions(+) > > diff --git a/drivers/iio/adc/ad4000.c b/drivers/iio/adc/ad4000.c > index 68ac77494263..8e31b42534f5 100644 > --- a/drivers/iio/adc/ad4000.c > +++ b/drivers/iio/adc/ad4000.c > @@ -137,6 +137,41 @@ static const struct ad4000_time_spec ad4020_t_spec = { > .t_quiet2_ns = 60, > }; > > +/* AD7983, AD7984 */ > +static const struct ad4000_time_spec ad7983_t_spec = { > + .t_conv_ns = 500, I'm sure there are diffing opinions on this but I would prefer an explicit .t_quiet2_ns = 0, so we know that it wasn't omitted on accident. Or a group comment to say that these chips don't need any quite time. In any case... Reviewed-by: David Lechner