From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C2F02EFDA5 for ; Fri, 31 Oct 2025 08:08:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761898099; cv=none; b=osCwAsHN8rtPGrZVqBpQhr7iyWFHF2d6RHPIbEK0Wq32dZ+WEwGXm//4Gyyw2V1a25EIj2TKtiLg5CmUful2xjfLhhS45vvFkL3yvua5aC89DuC9K4btxRQ0841QxST8TULeETd8k36mHDeJk+4RIU//EpNsxe2R9p9Opg/bKTc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761898099; c=relaxed/simple; bh=CzB7puzpaIg4J5iJ4aYQ3T5femYSZ2tisd4ljWkriQk=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=kWCtHigR3rbEyDSl8XMQ9rCkVU7HiekAGIPx82dsm7s9Oi/B4wQIWfLE/GXcb9HxxbI0oT0h4GQr19HsQKrWXBsFniajhezYzaZZnL6X7tJuVEv5rCjByliOK+yPDhZ2l1rx5pH5wNen6hEPshqmxUVo9EgCaEP4wkbKXAQZnlk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=EygcnUOL; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="EygcnUOL" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-63c0c9a408aso2978659a12.3 for ; Fri, 31 Oct 2025 01:08:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1761898096; x=1762502896; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:organization :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=CzB7puzpaIg4J5iJ4aYQ3T5femYSZ2tisd4ljWkriQk=; b=EygcnUOLoLGkEq3c6sES639A2R/ouoOdcsDgffdnu4Hmh8qd4ZlFXsFwserDdnwhUt B88Y3Z6PoR2Df4tQaqWi0jgLfRyQbzxoo9pfUEO/dGnfz4whSnc/tG8CjcJucaf/8Ti4 zK4HusCTCmJZHX6FnX0SB5EWo82VqdjBpqIB8/2ZUFRCqBp1vRmovfy9yYw7GAhfQ807 4KkEWlpnjjafGQld4R75VsTCMAA8+dF0qHAILkM6yWBcakud4abf/RicuWd0+i/N5UYV p3TjrohuRQGLDKf6jQ7QnuWW0H79sV6EhmsHzQavcdFsFhQBD9Ixh9+bQjHtfEYSeXH4 Z4xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761898096; x=1762502896; h=mime-version:user-agent:content-transfer-encoding:organization :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CzB7puzpaIg4J5iJ4aYQ3T5femYSZ2tisd4ljWkriQk=; b=TkTmDcBcQTnhSayTf6YbOseR0fOdPHfd0jEZ2N6sMFQcELHoIiw+MzWY9rCjxzWlNB LbuarbHind8/02419SSHzNT60MDDgNvi8zdXTpA5mBsu9xI87OxmpIolFQTwllWWfGE8 MaavF+tJa44Xa2vZAz9CFIU8jpqusLr2N5Ji+XwAiXOR70JfTmdd2scWUFGwmoSXw4+L wXyBT9hLaSLtAzBCnVwbI+gEkTBZs1ZaWkGlwJkL7ST+5yKieRujBsCwGE01m/dd8mqy KD2ldxAoGuakMRtFkExTWij0a6KI7sdKQXQUPKciM1+yorjgpyWKvchMTnPPaS2JOC80 erLQ== X-Forwarded-Encrypted: i=1; AJvYcCWTEldfK8rgaRXft6fd8ihSrZO8Zgv2eeILqyam1v71NBWpHwfXYtu8m7sNAs/xIkO59JF6YGq5Nxk=@vger.kernel.org X-Gm-Message-State: AOJu0YyDtdvDWJgUTipP3T3C6xWTUHGk0nz8prmu1cTRl15e05YVEGZE gv5rJm60gQ/esoSTShX2QmWV6MJqeakPlGa5Z7JerjOXNuRa7fMEUIfT9ZWNxQCUHVg= X-Gm-Gg: ASbGnctavezI2v20gxkhZBk2QXVH+dPCmF3mq3v1lauKrvaGmr6blnu9Mje2CtcDFX/ N75NfaEgYMiJ2duVNWFxD+Jfy5q+WhxzgNZ2IEYy37sKlXJ6qV/gRYgluL04kZLByAsZLjzAB5g SIIZKxo/5icg6al3a0KVu5uzbZaCBhC7xoOwFjJzS+/a1F3ZKYQa/T4EwLrJNnCxJ3LKjo0ujFe ZP4QzgGuqbYzLTlby+Qd3ssOUfmlKR19qXM47i+7gCDLi5RqOwXQkkTjqJFIJWGsau+UTfIA9Lt 9oweheMKsrRvdnpMlZDyB3p9CyXHNmt8mIR/r04Af/KvA5x53Hkz3fQ24oJtQixDZFeBgy+Ppor As9+j6K5sHklCNqt95Nk7aiuIMhPYkfnDxX6X2je1+WEsaNv3cwSDjKHOzYPvt+22hntELv4Ykj GUNwMlNfhScdwBCikzkH3Hdj+auN1ZfquriVnBnQNP8oTFMNE04w== X-Google-Smtp-Source: AGHT+IFs6OpBylfnRV7ubkY2/lHlHIFJ6CS/jmWmal20du9mmcOwOV8fb1bm1XtSMxm869tePKbLmw== X-Received: by 2002:a05:6402:42c4:b0:633:7017:fcbc with SMTP id 4fb4d7f45d1cf-64076faddecmr2151846a12.15.1761898096076; Fri, 31 Oct 2025 01:08:16 -0700 (PDT) Received: from [10.203.83.168] (mob-176-247-67-93.net.vodafone.it. [176.247.67.93]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6407b42821bsm1034663a12.22.2025.10.31.01.08.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Oct 2025 01:08:15 -0700 (PDT) Message-ID: Subject: Re: [PATCH 2/9] iio: imu: st_lsm6dsx: make event_settings more generic From: Francesco Lavra To: Lorenzo Bianconi Cc: Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 31 Oct 2025 09:08:14 +0100 In-Reply-To: References: <20251030072752.349633-1-flavra@baylibre.com> <20251030072752.349633-3-flavra@baylibre.com> Organization: BayLibre Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2025-10-30 at 17:44 +0100, Lorenzo Bianconi wrote: > On Oct 30, Francesco Lavra wrote: > > The st_lsm6dsx_event_settings structure contains fields specific > > for one event type (wakeup). In preparation for adding support for > > more event types, introduce an event id enum and a generic event > > source structure, and replace wakeup-specific data in struct > > st_lsm6dsx_event_settings with an array of event source structures. > >=20 > > Signed-off-by: Francesco Lavra > > --- > > =C2=A0drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 |=C2=A0 21 ++- > > =C2=A0drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 136 +++++++++++---= ----- > > =C2=A02 files changed, 96 insertions(+), 61 deletions(-) > >=20 > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h > > b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h > > index db863bd1898d..05689887f7ec 100644 > > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h > > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h > > @@ -221,14 +221,23 @@ struct st_lsm6dsx_shub_settings { > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0u8 pause; > > =C2=A0}; > > =C2=A0 > > +enum st_lsm6dsx_event_id { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ST_LSM6DSX_EVENT_WAKEUP, > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ST_LSM6DSX_EVENT_MAX > > +}; > > + > > +struct st_lsm6dsx_event_src { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct st_lsm6dsx_reg value; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0u8 status_reg; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0u8 status_mask; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0u8 status_x_mask; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0u8 status_y_mask; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0u8 status_z_mask; >=20 > you can use st_lsm6dsx_reg here. Do you mean replacing the status_* fields with 4 struct st_lsm6dsx_reg fields (one for the global status flag, and one for each axis)?