[PATCH] hid: hid-sensor-prox: Add more data field for hysteresis parsing

[PATCH] hid: hid-sensor-prox: Add more data field for hysteresis parsing

[Song Hongyan]

Add HID_USAGE_SENSOR_HUMAN_PRESENCE support for Human Presence sensitivity
parsing, in case some implementation uses it as sensitivity modifier.

Signed-off-by: Song Hongyan <hongyan.song@intel.com>
---
 drivers/iio/light/hid-sensor-prox.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/iio/light/hid-sensor-prox.c b/drivers/iio/light/hid-sensor-prox.c
index 45ca056..73fced8 100644
--- a/drivers/iio/light/hid-sensor-prox.c
+++ b/drivers/iio/light/hid-sensor-prox.c
@@ -240,6 +240,13 @@ static int prox_parse_report(struct platform_device *pdev,
 			st->common_attributes.sensitivity.index,
 			st->common_attributes.sensitivity.report_id);
 	}
+	if (st->common_attributes.sensitivity.index < 0)
+		sensor_hub_input_get_attribute_info(hsdev,
+			HID_FEATURE_REPORT, usage_id,
+			HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_ABS |
+			HID_USAGE_SENSOR_HUMAN_PRESENCE,
+			&st->common_attributes.sensitivity);
+
 	return ret;
 }
 
-- 
1.9.1

Re: [PATCH] hid: hid-sensor-prox: Add more data field for hysteresis parsing

[Jonathan Cameron]

On 13/02/17 09:54, Song Hongyan wrote:
> Add HID_USAGE_SENSOR_HUMAN_PRESENCE support for Human Presence sensitivity
> parsing, in case some implementation uses it as sensitivity modifier.
> 
> Signed-off-by: Song Hongyan <hongyan.song@intel.com>
Do we want to perhaps indicate to userspace in some way that this is what is being
reported? (not that I have any idea how a proximity sensor could potentially tell
a human from a passing cat for example ;)

Otherwise, I'm fine with this but would like an Ack from Srinivas.
> ---
>  drivers/iio/light/hid-sensor-prox.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/iio/light/hid-sensor-prox.c b/drivers/iio/light/hid-sensor-prox.c
> index 45ca056..73fced8 100644
> --- a/drivers/iio/light/hid-sensor-prox.c
> +++ b/drivers/iio/light/hid-sensor-prox.c
> @@ -240,6 +240,13 @@ static int prox_parse_report(struct platform_device *pdev,
>  			st->common_attributes.sensitivity.index,
>  			st->common_attributes.sensitivity.report_id);
>  	}
> +	if (st->common_attributes.sensitivity.index < 0)
> +		sensor_hub_input_get_attribute_info(hsdev,
> +			HID_FEATURE_REPORT, usage_id,
> +			HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_ABS |
> +			HID_USAGE_SENSOR_HUMAN_PRESENCE,
> +			&st->common_attributes.sensitivity);
> +
>  	return ret;
>  }
>  
> 

Re: [PATCH] hid: hid-sensor-prox: Add more data field for hysteresis parsing

[Pandruvada, Srinivas]

T24gU3VuLCAyMDE3LTAyLTE5IGF0IDExOjUwICswMDAwLCBKb25hdGhhbiBDYW1lcm9uIHdyb3Rl
Og0KPiBPbiAxMy8wMi8xNyAwOTo1NCwgU29uZyBIb25neWFuIHdyb3RlOg0KPiA+IEFkZCBISURf
VVNBR0VfU0VOU09SX0hVTUFOX1BSRVNFTkNFIHN1cHBvcnQgZm9yIEh1bWFuIFByZXNlbmNlDQo+
ID4gc2Vuc2l0aXZpdHkNCj4gPiBwYXJzaW5nLCBpbiBjYXNlIHNvbWUgaW1wbGVtZW50YXRpb24g
dXNlcyBpdCBhcyBzZW5zaXRpdml0eQ0KPiA+IG1vZGlmaWVyLg0KPiA+IA0KPiA+IFNpZ25lZC1v
ZmYtYnk6IFNvbmcgSG9uZ3lhbiA8aG9uZ3lhbi5zb25nQGludGVsLmNvbT4NCkFja2VkLWJ5OiBT
cmluaXZhcyBQYW5kcnV2YWRhIDxzcmluaXZhcy5wYW5kcnV2YWRhQGxpbnV4LmludGVsLmNvbT4N
Cg0KPiANCj4gRG8gd2Ugd2FudCB0byBwZXJoYXBzIGluZGljYXRlIHRvIHVzZXJzcGFjZSBpbiBz
b21lIHdheSB0aGF0IHRoaXMgaXMNCj4gd2hhdCBpcyBiZWluZw0KPiByZXBvcnRlZD8gKG5vdCB0
aGF0IEkgaGF2ZSBhbnkgaWRlYSBob3cgYSBwcm94aW1pdHkgc2Vuc29yIGNvdWxkDQo+IHBvdGVu
dGlhbGx5IHRlbGwNCj4gYSBodW1hbiBmcm9tIGEgcGFzc2luZyBjYXQgZm9yIGV4YW1wbGUgOykN
Cj4gDQo+IE90aGVyd2lzZSwgSSdtIGZpbmUgd2l0aCB0aGlzIGJ1dCB3b3VsZCBsaWtlIGFuIEFj
ayBmcm9tIFNyaW5pdmFzLg0KPiA+IC0tLQ0KPiA+IMKgZHJpdmVycy9paW8vbGlnaHQvaGlkLXNl
bnNvci1wcm94LmMgfCA3ICsrKysrKysNCj4gPiDCoDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlv
bnMoKykNCj4gPiANCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9paW8vbGlnaHQvaGlkLXNlbnNv
ci1wcm94LmMNCj4gPiBiL2RyaXZlcnMvaWlvL2xpZ2h0L2hpZC1zZW5zb3ItcHJveC5jDQo+ID4g
aW5kZXggNDVjYTA1Ni4uNzNmY2VkOCAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL2lpby9saWdo
dC9oaWQtc2Vuc29yLXByb3guYw0KPiA+ICsrKyBiL2RyaXZlcnMvaWlvL2xpZ2h0L2hpZC1zZW5z
b3ItcHJveC5jDQo+ID4gQEAgLTI0MCw2ICsyNDAsMTMgQEAgc3RhdGljIGludCBwcm94X3BhcnNl
X3JlcG9ydChzdHJ1Y3QNCj4gPiBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYsDQo+ID4gwqAJCQlzdC0+
Y29tbW9uX2F0dHJpYnV0ZXMuc2Vuc2l0aXZpdHkuaW5kZXgsDQo+ID4gwqAJCQlzdC0NCj4gPiA+
Y29tbW9uX2F0dHJpYnV0ZXMuc2Vuc2l0aXZpdHkucmVwb3J0X2lkKTsNCj4gPiDCoAl9DQo+ID4g
KwlpZiAoc3QtPmNvbW1vbl9hdHRyaWJ1dGVzLnNlbnNpdGl2aXR5LmluZGV4IDwgMCkNCj4gPiAr
CQlzZW5zb3JfaHViX2lucHV0X2dldF9hdHRyaWJ1dGVfaW5mbyhoc2RldiwNCj4gPiArCQkJSElE
X0ZFQVRVUkVfUkVQT1JULCB1c2FnZV9pZCwNCj4gPiArCQkJSElEX1VTQUdFX1NFTlNPUl9EQVRB
X01PRF9DSEFOR0VfU0VOU0lUSVZJDQo+ID4gVFlfQUJTIHwNCj4gPiArCQkJSElEX1VTQUdFX1NF
TlNPUl9IVU1BTl9QUkVTRU5DRSwNCj4gPiArCQkJJnN0LT5jb21tb25fYXR0cmlidXRlcy5zZW5z
aXRpdml0eSk7DQo+ID4gKw0KPiA+IMKgCXJldHVybiByZXQ7DQo+ID4gwqB9DQo+ID4gwqANCj4g
PiANCj4gDQo+IA==