From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0AA0C433ED for ; Thu, 15 Apr 2021 16:58:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C091A611AC for ; Thu, 15 Apr 2021 16:58:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233330AbhDOQ66 (ORCPT ); Thu, 15 Apr 2021 12:58:58 -0400 Received: from mga14.intel.com ([192.55.52.115]:61370 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233520AbhDOQ65 (ORCPT ); Thu, 15 Apr 2021 12:58:57 -0400 IronPort-SDR: bLDosqDwcXY/y5y1FEmNCOiHvYgcyjX7gcet6gE/EaHljwj+YWt6i2Nh9onlyhFQfD9xqqdPFm shbT5Y+DLlkw== X-IronPort-AV: E=McAfee;i="6200,9189,9955"; a="194453902" X-IronPort-AV: E=Sophos;i="5.82,225,1613462400"; d="scan'208";a="194453902" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2021 09:58:34 -0700 IronPort-SDR: dkLvmpp8egi7T6waBo+Wt5pAWBIoXfsgpbhmn11sugVkhAbhAl9pu1fKMuk5wCyQpK8P0z68xB iyKdALIwOm5g== X-IronPort-AV: E=Sophos;i="5.82,225,1613462400"; d="scan'208";a="421750220" Received: from jgrenin-mobl.amr.corp.intel.com ([10.209.105.61]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2021 09:58:33 -0700 Message-ID: Subject: Re: [PATCH] iio: hid-sensors: select IIO_TRIGGERED_BUFFER under HID_SENSOR_IIO_TRIGGER From: Srinivas Pandruvada To: Alexandru Ardelean , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: jic23@kernel.org, linux@deviqon.com, Thomas Deutschmann Date: Thu, 15 Apr 2021 09:58:33 -0700 In-Reply-To: <20210414084955.260117-1-aardelean@deviqon.com> References: <20210414084955.260117-1-aardelean@deviqon.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, 2021-04-14 at 11:49 +0300, Alexandru Ardelean wrote: > During commit 067fda1c065ff ("iio: hid-sensors: move triggered buffer > setup into hid_sensor_setup_trigger"), the > iio_triggered_buffer_{setup,cleanup}() functions got moved under the > hid-sensor-trigger module. > > The above change works fine, if any of the sensors get built. > However, when > only the common hid-sensor-trigger module gets built (and none of the > drivers), then the IIO_TRIGGERED_BUFFER symbol isn't > selected/enforced. > > Previously, each driver would enforce/select the IIO_TRIGGERED_BUFFER > symbol. With this change the HID_SENSOR_IIO_TRIGGER (for the > hid-sensor-trigger module) will enforce that IIO_TRIGGERED_BUFFER > gets > selected. > > All HID sensor drivers select the HID_SENSOR_IIO_TRIGGER symbol. So, > this > change removes the IIO_TRIGGERED_BUFFER enforcement from each driver. > > Fixes: 067fda1c065ff ("iio: hid-sensors: move triggered buffer setup > into hid_sensor_setup_trigger") > Reported-by: Thomas Deutschmann > Cc: Srinivas Pandruvada > Signed-off-by: Alexandru Ardelean Acked-by: Srinivas Pandruvada > --- > drivers/iio/accel/Kconfig | 1 - > drivers/iio/common/hid-sensors/Kconfig | 1 + > drivers/iio/gyro/Kconfig | 1 - > drivers/iio/humidity/Kconfig | 1 - > drivers/iio/light/Kconfig | 2 -- > drivers/iio/magnetometer/Kconfig | 1 - > drivers/iio/orientation/Kconfig | 2 -- > drivers/iio/pressure/Kconfig | 1 - > drivers/iio/temperature/Kconfig | 1 - > 9 files changed, 1 insertion(+), 10 deletions(-) > > diff --git a/drivers/iio/accel/Kconfig b/drivers/iio/accel/Kconfig > index cceda3cecbcf..8b1723635cce 100644 > --- a/drivers/iio/accel/Kconfig > +++ b/drivers/iio/accel/Kconfig > @@ -229,7 +229,6 @@ config DMARD10 > config HID_SENSOR_ACCEL_3D > depends on HID_SENSOR_HUB > select IIO_BUFFER > - select IIO_TRIGGERED_BUFFER > select HID_SENSOR_IIO_COMMON > select HID_SENSOR_IIO_TRIGGER > tristate "HID Accelerometers 3D" > diff --git a/drivers/iio/common/hid-sensors/Kconfig > b/drivers/iio/common/hid-sensors/Kconfig > index 24d492567336..2a3dd3b907be 100644 > --- a/drivers/iio/common/hid-sensors/Kconfig > +++ b/drivers/iio/common/hid-sensors/Kconfig > @@ -19,6 +19,7 @@ config HID_SENSOR_IIO_TRIGGER > tristate "Common module (trigger) for all HID Sensor IIO > drivers" > depends on HID_SENSOR_HUB && HID_SENSOR_IIO_COMMON && > IIO_BUFFER > select IIO_TRIGGER > + select IIO_TRIGGERED_BUFFER > help > Say yes here to build trigger support for HID sensors. > Triggers will be send if all requested attributes were read. > diff --git a/drivers/iio/gyro/Kconfig b/drivers/iio/gyro/Kconfig > index 5824f2edf975..20b5ac7ab66a 100644 > --- a/drivers/iio/gyro/Kconfig > +++ b/drivers/iio/gyro/Kconfig > @@ -111,7 +111,6 @@ config FXAS21002C_SPI > config HID_SENSOR_GYRO_3D > depends on HID_SENSOR_HUB > select IIO_BUFFER > - select IIO_TRIGGERED_BUFFER > select HID_SENSOR_IIO_COMMON > select HID_SENSOR_IIO_TRIGGER > tristate "HID Gyroscope 3D" > diff --git a/drivers/iio/humidity/Kconfig > b/drivers/iio/humidity/Kconfig > index 6549fcf6db69..2de5494e7c22 100644 > --- a/drivers/iio/humidity/Kconfig > +++ b/drivers/iio/humidity/Kconfig > @@ -52,7 +52,6 @@ config HID_SENSOR_HUMIDITY > tristate "HID Environmental humidity sensor" > depends on HID_SENSOR_HUB > select IIO_BUFFER > - select IIO_TRIGGERED_BUFFER > select HID_SENSOR_IIO_COMMON > select HID_SENSOR_IIO_TRIGGER > help > diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig > index 33ad4dd0b5c7..917f9becf9c7 100644 > --- a/drivers/iio/light/Kconfig > +++ b/drivers/iio/light/Kconfig > @@ -256,7 +256,6 @@ config ISL29125 > config HID_SENSOR_ALS > depends on HID_SENSOR_HUB > select IIO_BUFFER > - select IIO_TRIGGERED_BUFFER > select HID_SENSOR_IIO_COMMON > select HID_SENSOR_IIO_TRIGGER > tristate "HID ALS" > @@ -270,7 +269,6 @@ config HID_SENSOR_ALS > config HID_SENSOR_PROX > depends on HID_SENSOR_HUB > select IIO_BUFFER > - select IIO_TRIGGERED_BUFFER > select HID_SENSOR_IIO_COMMON > select HID_SENSOR_IIO_TRIGGER > tristate "HID PROX" > diff --git a/drivers/iio/magnetometer/Kconfig > b/drivers/iio/magnetometer/Kconfig > index 5d4ffd66032e..74ad5701c6c2 100644 > --- a/drivers/iio/magnetometer/Kconfig > +++ b/drivers/iio/magnetometer/Kconfig > @@ -95,7 +95,6 @@ config MAG3110 > config HID_SENSOR_MAGNETOMETER_3D > depends on HID_SENSOR_HUB > select IIO_BUFFER > - select IIO_TRIGGERED_BUFFER > select HID_SENSOR_IIO_COMMON > select HID_SENSOR_IIO_TRIGGER > tristate "HID Magenetometer 3D" > diff --git a/drivers/iio/orientation/Kconfig > b/drivers/iio/orientation/Kconfig > index a505583cc2fd..396cbbb867f4 100644 > --- a/drivers/iio/orientation/Kconfig > +++ b/drivers/iio/orientation/Kconfig > @@ -9,7 +9,6 @@ menu "Inclinometer sensors" > config HID_SENSOR_INCLINOMETER_3D > depends on HID_SENSOR_HUB > select IIO_BUFFER > - select IIO_TRIGGERED_BUFFER > select HID_SENSOR_IIO_COMMON > select HID_SENSOR_IIO_TRIGGER > tristate "HID Inclinometer 3D" > @@ -20,7 +19,6 @@ config HID_SENSOR_INCLINOMETER_3D > config HID_SENSOR_DEVICE_ROTATION > depends on HID_SENSOR_HUB > select IIO_BUFFER > - select IIO_TRIGGERED_BUFFER > select HID_SENSOR_IIO_COMMON > select HID_SENSOR_IIO_TRIGGER > tristate "HID Device Rotation" > diff --git a/drivers/iio/pressure/Kconfig > b/drivers/iio/pressure/Kconfig > index 689b978db4f9..fc0d3cfca418 100644 > --- a/drivers/iio/pressure/Kconfig > +++ b/drivers/iio/pressure/Kconfig > @@ -79,7 +79,6 @@ config DPS310 > config HID_SENSOR_PRESS > depends on HID_SENSOR_HUB > select IIO_BUFFER > - select IIO_TRIGGERED_BUFFER > select HID_SENSOR_IIO_COMMON > select HID_SENSOR_IIO_TRIGGER > tristate "HID PRESS" > diff --git a/drivers/iio/temperature/Kconfig > b/drivers/iio/temperature/Kconfig > index c5482983f568..f20ae3c963cb 100644 > --- a/drivers/iio/temperature/Kconfig > +++ b/drivers/iio/temperature/Kconfig > @@ -45,7 +45,6 @@ config HID_SENSOR_TEMP > tristate "HID Environmental temperature sensor" > depends on HID_SENSOR_HUB > select IIO_BUFFER > - select IIO_TRIGGERED_BUFFER > select HID_SENSOR_IIO_COMMON > select HID_SENSOR_IIO_TRIGGER > help