From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83BC5C433FE for ; Mon, 17 Oct 2022 05:44:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229824AbiJQFoQ (ORCPT ); Mon, 17 Oct 2022 01:44:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229660AbiJQFoP (ORCPT ); Mon, 17 Oct 2022 01:44:15 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF67554C91 for ; Sun, 16 Oct 2022 22:44:13 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id x18so12684406ljm.1 for ; Sun, 16 Oct 2022 22:44:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8qJRPjP/GjwPxmkPHxIyW5T+0ZUEadjBIJapgn8Budg=; b=XOaJtcDvIpuin13njBxkPd+x3KkyTTYM0MhgiUp2XA8iS1C42WZwyNpoKOT0QkZQst hEyRmnxiWOZB0/45GaW26mkDAIq+5sZWHIesaQQkHBrfnNbfKQDvOWl3pLhbhdJ4tQDu hDkQU80eDG1HQweZ6OfQTHwbcctpHZVNPKg0/diFPFjmP71T7VzGZmcaVNA0r17Fnprs uuuZebUni1EXRaHSLGpDB93+QSpJFNDMH9HL3Ao0S0dGrjPqKTWEUtuZTsAyGaBdYS4i Drz29Ag0M7mTelOpKRMGlTS2Pb53ng8bBrebBPSxqdSF78f+wJjo3TcYlz7IZJ6o8tab rL0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8qJRPjP/GjwPxmkPHxIyW5T+0ZUEadjBIJapgn8Budg=; b=7jWh7ac0hvTd8bNbrIEUCVImXYYXHnUUW8cp9YGXvcdhMi2fIw74kZD8d7gosXN8oG VSNalCwZl2spme6iGJ1dM9YFpCDjNFYOOpJ/l1drc+rXHBdHzkDKlXAQ73x1ktz3JBty F9mbvpGDbeZSagfF0zP7wqH4xB6284mNKX+PhFUMEbFNmqsacdqaV0wUf7FWoCCpLL54 q3/9SaqHl7CWnbsglrDKV29YAbVjajo8Ijk+nXpThIs6I1xjkCgmkw2G7ZbIH3r5QwcB Oz91U8se6NZEhn4y3fG2DiFFfNmvvw3w3WU8aFXwYBPMQSZ6tBGhdw4CYoCzvgVokN+u p47A== X-Gm-Message-State: ACrzQf1UHQH2hHVzelUKTG6jGJeAWdHbAJFdgsVh8GUsCpiCuoMqCRfr bximAkkm+tSIEH1D6O5xif0= X-Google-Smtp-Source: AMsMyM7vOPLNfIC+9M2utDentjww9cBDxs88uOj0dPSEsuydQyeahqPiHaI0ZxawN2A04qbhrUeI7g== X-Received: by 2002:a2e:9395:0:b0:26f:a73e:1357 with SMTP id g21-20020a2e9395000000b0026fa73e1357mr3443340ljh.368.1665985451816; Sun, 16 Oct 2022 22:44:11 -0700 (PDT) Received: from ?IPV6:2001:14ba:16f3:4a00::4? (dc75zzyyyyyyyyyyyyycy-3.rev.dnainternet.fi. [2001:14ba:16f3:4a00::4]) by smtp.gmail.com with ESMTPSA id q3-20020a2eb4a3000000b00262fae1ffe6sm1350931ljm.110.2022.10.16.22.44.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Oct 2022 22:44:11 -0700 (PDT) Message-ID: Date: Mon, 17 Oct 2022 08:44:10 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 07/14] iio: st_sensors: core and lsm9ds0 switch to devm_regulator_bulk_get_enable() Content-Language: en-US To: Jonathan Cameron , linux-iio@vger.kernel.org Cc: Matti Vaittinen , Cosmin Tanislav , Jagath Jog J , Sean Nyekjaer , Dmitry Rokosov , Linus Walleij , Andy Shevchenko , Michael Hennerich , Lorenzo Bianconi , Martyn Welch , Gwendal Grignou , Stephen Boyd , Tomasz Duszynski , Jonathan Cameron References: <20221016163409.320197-1-jic23@kernel.org> <20221016163409.320197-8-jic23@kernel.org> From: Matti Vaittinen In-Reply-To: <20221016163409.320197-8-jic23@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On 10/16/22 19:34, Jonathan Cameron wrote: > From: Jonathan Cameron > > These drivers only turns the power on at probe and off via a custom > devm_add_action_or_reset() callback. The two regulators were handled > separately so also switch to bulk registration. > The new devm_regulator_bulk_get_enable() replaces all this boilerplate > code. > > Signed-off-by: Jonathan Cameron > Cc: Linus Walleij > Cc: Andy Shevchenko > > --- I like this change. Especially since the st_sensors_power_enable() is exported. Looks much safer (to me) now. Reviewed-by: Matti Vaittinen -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~