From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDB09196D9A for ; Thu, 5 Dec 2024 19:01:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733425318; cv=none; b=j5OYdP7M/fvfbnAIcAnZr9It9vJEJmZXSSTnq5SXB85cFIT2oyON6Gc2cVnnf+hFWojgtluy4eYeaYAREeV3e/XbwyUwr3Lfiz/+Fw6wC5xVRvlgnz7W228W0HKnKkNAMpgONgW86gClL2iV3/mm9cVqiHkfFsyr6TYVPiPy84M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733425318; c=relaxed/simple; bh=8ik38w9GU2WtkRtkZaXq6QpH4+Y0ahI6eayxAGSMAWg=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=FJrfKBmIiznO0t9FEATmNHBxiKluJu8k2nUoKkD9VzfNgvb7Y8XfnQj3BQVm+cLUNDQR2vbqtoh12wYlnxQn8RswT+t0hDGiBuQYPZGOfCzeMnC6UVOPYO49FZuMaG6iAvz3lLCe2kKfA/ewoEVGv811WqSPGeLXGpplxvhgLkw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=AKRFRzeb; arc=none smtp.client-ip=209.85.167.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="AKRFRzeb" Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-3ea696c4dcaso810924b6e.2 for ; Thu, 05 Dec 2024 11:01:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1733425315; x=1734030115; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=IaFOO/mfjUBixXAYtvSMoA7J8PbrmSflkGjEoxaTBzw=; b=AKRFRzebX8wl24LMA9NWbIz+LXBGvL4732lXcCo1vADffGbQikUR/1Gy7pBWnlHzMx xusjQ1rAvMLVqgSeaRsx5HXRNlsAB4ty7EgKeqOIWwFnb9FsFIQB+dvrdvo9sYJfyWCf ynWO066KlOKGcceoUnubch0Kut/rnrV3UBWyHlGQBh5mTsQBU9/5FGdd528nj9ax/vB4 h7CUliDmd7GXfsD5bpYdtaQgJBH9hY/KvGabfSORU+WIIJa702H3+e+N0AdccrdpR3l8 8/zMa3qhr1yhpOWvBzHvzkMsplQcnQigy3A7MMWtc4l934YkosBuDN4y/St6rxW31Hma /g0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733425315; x=1734030115; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IaFOO/mfjUBixXAYtvSMoA7J8PbrmSflkGjEoxaTBzw=; b=L/nM+JTq3EVWzfe887sI69rm9lMy3xIDiRndXnhjIGGGqnXWR/F5Cby2Teluzx6rGG O16U9JZJ8A6eVIQvHY5rFBvsKuP4Wt/BJUwMvgwWqJeBV3RAVZxOEngIgiw0Pvnw8Rla 9Jwzp2auydbGhBKdHApkZSTCTLNu7w+GxMj/zWw3PiVsHxgB2Eo74JTcPyarv6xNdaUf 4k8twIR01IYLD7TkFQO048KtcY15hFkDfy8u9k4esZWSx0us2nU91NzOWd6XbaFnJOdo zQHwnhLFF91fPixTt5BOrCvGDPvqk31mHS6BNfjiqK78j1WOLtXC3ZxXnJ0i943G5Mmr vE4g== X-Forwarded-Encrypted: i=1; AJvYcCUA9itmH3UaU9NHangBzBIg++5YGvnWHoXk/ipdlwGhYo0Wki1Zh56+gktcA11E5asDzPaDyxcACCM=@vger.kernel.org X-Gm-Message-State: AOJu0Yye7Q7e6f8Ur01HPceRkiPO0UYrUEAWTl/kgEyrGffqTaWdO97j VOkc959krV8j9WUjxZQ5H5aGokX0y18nOnsxmNt1LISr7rQLbtLzKFyj4Miq9hQ= X-Gm-Gg: ASbGncsq3Pu6DTk6Rv+1toM2EYV690DzhTZRlCpeM1qtWX0tDrbHlO68SP0hbjm47yP sCsL2v0iSF7VoTXtRgMkVMXqP1gibiKtf1HBi7PjELWvRUhP2BSpeeuPhQj4qn0srrYO02PaVRK O7mxevB7udWRasU9L4C8ST7rOTHGC7eysrX/cmoZhboC+p1tHg0sqc8sjBuwjjXx0EGlLVxVG8o YaCRzV3akrIPqLmUu/Ytf/qIdiZInZ1AsVFhtRrDVYwuhHVoj8UrNhwtPX0P7dvE+PKmgPKCh9D 9a6y4Xei5jI= X-Google-Smtp-Source: AGHT+IFUDmVuFaNfj2c7OVLcgWFCxMQtCVuhMU/p4FrORrns3HwZaKiwq8nLNxh6O55/Euxmzx2I2w== X-Received: by 2002:a05:6808:1898:b0:3e6:2772:2a4b with SMTP id 5614622812f47-3eb19c168a3mr59071b6e.9.1733425314900; Thu, 05 Dec 2024 11:01:54 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3eb07869655sm408646b6e.50.2024.12.05.11.01.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Dec 2024 11:01:53 -0800 (PST) Message-ID: Date: Thu, 5 Dec 2024 13:01:51 -0600 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] iio: adc: add Nuvoton NCT720x ADC driver From: David Lechner To: Eason Yang , avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, jic23@kernel.org, lars@metafoo.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, nuno.sa@analog.com, javier.carrasco.cruz@gmail.com, andriy.shevchenko@linux.intel.com, marcelo.schmitt@analog.com, olivier.moysan@foss.st.com, mitrutzceclan@gmail.com, tgamblin@baylibre.com, matteomartelli3@gmail.com, alisadariana@gmail.com, gstols@baylibre.com, thomas.bonnefille@bootlin.com, ramona.nechita@analog.com, mike.looijmans@topic.nl, chanh@os.amperecomputing.com, KWLIU@nuvoton.com, yhyang2@nuvoton.com Cc: openbmc@lists.ozlabs.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241203091540.3695650-1-j2anfernee@gmail.com> <20241203091540.3695650-3-j2anfernee@gmail.com> <8f5ca298-54ba-4274-a35d-83be868fcfc8@baylibre.com> Content-Language: en-US In-Reply-To: <8f5ca298-54ba-4274-a35d-83be868fcfc8@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/5/24 12:22 PM, David Lechner wrote: > On 12/3/24 3:15 AM, Eason Yang wrote: >> +static int nct720x_read_raw(struct iio_dev *indio_dev, >> + struct iio_chan_spec const *chan, >> + int *val, int *val2, long mask) >> +{ >> + int index = nct720x_chan_to_index[chan->address]; >> + u16 volt; >> + unsigned int value; >> + int err; >> + struct nct720x_chip_info *chip = iio_priv(indio_dev); >> + >> + if (chan->type != IIO_VOLTAGE) >> + return -EOPNOTSUPP; >> + >> + guard(mutex)(&chip->access_lock); >> + switch (mask) { >> + case IIO_CHAN_INFO_RAW: >> + err = regmap_read(chip->regmap16, REG_VIN[index], &value); >> + if (err < 0) >> + return err; >> + volt = (u16)value; >> + *val = volt >> 3; > > It seems strange that this is 13 bits when the chips are 8 and 12 bit. > >> + return IIO_VAL_INT; >> + case IIO_CHAN_INFO_SCALE: >> + /* From the datasheet, we have to multiply by 0.0004995 */ > > The scale is the same for both 8 bit and 12 bit chips? > >> + *val = 0; >> + *val2 = 499500; >> + return IIO_VAL_INT_PLUS_NANO; >> + default: >> + return -EINVAL; >> + } >> +} >> + Sorry, I got confused. The difference between the two chips is the number of channels, not the number of bits. Please ignore these two comments.