From: Angel Iglesias <ang.iglesiasg@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>, kbuild@lists.01.org
Cc: lkp@intel.com, kbuild-all@lists.01.org,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Paul Cercueil <paul@crapouillou.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] iio: pressure: bmp280: Add support for BMP380 sensor family
Date: Mon, 27 Jun 2022 16:48:01 +0200 [thread overview]
Message-ID: <a57e1d14dda4f902cedddcfcea9a16a8e58316e6.camel@gmail.com> (raw)
In-Reply-To: <202206260803.ctZKSyI9-lkp@intel.com>
On lun, 2022-06-27 at 10:37 +0300, Dan Carpenter wrote:
> Hi Angel,
>
> url:
> https://github.com/intel-lab-lkp/linux/commits/Angel-Iglesias/dt-bindings-iio-pressure-bmp085-Add-BMP380-compatible-string/20220625-231424
> base:
> https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
> config: i386-randconfig-m021
> compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> smatch warnings:
> drivers/iio/pressure/bmp280-core.c:1000 bmp380_chip_config() warn:
> should this be a bitwise op?
>
> vim +1000 drivers/iio/pressure/bmp280-core.c
>
> 56e3f8aecddacd Angel Iglesias 2022-06-25 988 if (ret < 0)
> {
> 56e3f8aecddacd Angel Iglesias 2022-06-25
> 989 dev_err(data->dev, "failed to write config
> register\n");
> 56e3f8aecddacd Angel Iglesias 2022-06-25
> 990 return ret;
> 56e3f8aecddacd Angel Iglesias 2022-06-25 991 }
> 56e3f8aecddacd Angel Iglesias 2022-06-25 992
> 56e3f8aecddacd Angel Iglesias 2022-06-25 993 /* check
> config error flag */
> 56e3f8aecddacd Angel Iglesias 2022-06-25 994 ret =
> regmap_read(data->regmap, BMP380_REG_ERROR, &tmp);
> 56e3f8aecddacd Angel Iglesias 2022-06-25 995 if (ret < 0)
> {
> 56e3f8aecddacd Angel Iglesias 2022-06-25
> 996 dev_err(data->dev,
> 56e3f8aecddacd Angel Iglesias 2022-06-25
> 997 "failed to read error register\n");
> 56e3f8aecddacd Angel Iglesias 2022-06-25
> 998 return ret;
> 56e3f8aecddacd Angel Iglesias 2022-06-25 999 }
> 56e3f8aecddacd Angel Iglesias 2022-06-25 @1000 if (tmp &&
> BMP380_ERR_CONF_MASK) {
>
> ^^^^^^^^^^^^^^^^^^^^^^^
> Looks like & BMP380_ERR_CONF_MASK was intended.
>
> 56e3f8aecddacd Angel Iglesias 2022-06-25
> 1001 dev_warn(data->dev,
> 56e3f8aecddacd Angel Iglesias 2022-06-25
> 1002 "sensor flagged configuration as
> incompatible\n");
> 56e3f8aecddacd Angel Iglesias 2022-06-25 1003 ret =
> -EINVAL;
> 56e3f8aecddacd Angel Iglesias 2022-06-25 1004 }
> 56e3f8aecddacd Angel Iglesias 2022-06-25 1005
> 56e3f8aecddacd Angel Iglesias 2022-06-25 1006 return ret;
> 56e3f8aecddacd Angel Iglesias 2022-06-25 1007 }
>
Thanks! that is an awkward mistake, my bad!
prev parent reply other threads:[~2022-06-27 14:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-25 15:09 [PATCH 2/3] iio: pressure: bmp280: Add support for BMP380 sensor family Angel Iglesias
2022-06-25 15:46 ` Jonathan Cameron
2022-06-27 15:42 ` Angel Iglesias
2022-07-16 16:03 ` Jonathan Cameron
2022-06-25 16:49 ` kernel test robot
2022-06-25 17:59 ` kernel test robot
2022-06-25 20:11 ` kernel test robot
2022-06-25 20:11 ` kernel test robot
2022-06-26 1:24 ` kernel test robot
2022-06-27 7:37 ` Dan Carpenter
2022-06-27 14:48 ` Angel Iglesias [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a57e1d14dda4f902cedddcfcea9a16a8e58316e6.camel@gmail.com \
--to=ang.iglesiasg@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=jic23@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=paul@crapouillou.net \
--cc=rafael.j.wysocki@intel.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox