From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yasin Lee <yasin.lee.x@outlook.com>, jic23@kernel.org
Cc: andy.shevchenko@gmail.com, lars@metafoo.de,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
nuno.a@analog.com, swboyd@chromium.org,
u.kleine-koenig@pengutronix.de, yasin.lee.x@gmail.com
Subject: Re: [PATCH v3 0/2] iio-proximity-hx9023s-Add-TYHX-HX9023S-sensor-driver
Date: Sun, 16 Jun 2024 09:45:33 +0200 [thread overview]
Message-ID: <a585d179-d401-4a38-8c6b-f02f3d880d8c@kernel.org> (raw)
In-Reply-To: <f907c2a9-94c0-493b-971b-c627244528ed@kernel.org>
On 31/05/2024 09:52, Krzysztof Kozlowski wrote:
> On 29/05/2024 06:57, Yasin Lee wrote:
>> From: Yasin Lee <yasin.lee.x@gmail.com>
>>
>> v3:
>> - Renamed the files to keep the file names consistent with the chip name.
>> - Removed custom bit operation macro definitions.
>> - Deleted redundant documentation that duplicated the Standard ABI.
>> - Deleted unused header files.
>> - Deleted unused register definitions.
>> - Changed parts of the code related to circuit design to be configurable through DTS.
>> - Removed unnecessary print statements.
>> - Fixed the error in hx9031as_write_event_val.
>> - Removed unnecessary threshold settings in the probe.
>> - Replaced enable_irq(data->client->irq) with interrupt enable register operations.
>> - Fixed style issues.
>
> Please do not ignore comments but respond to them. Go back to 15th of
> May and acknowledge all of them. You repeated every single issue...
Where did you responded to this?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-16 7:45 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 9:37 [PATCH] iio:proximity:hx9031as: Add TYHX HX9031AS/HX9023S sensor driver Yasin Lee
2024-05-10 10:26 ` Uwe Kleine-König
2024-06-19 7:40 ` Yasin Lee
2024-05-10 12:29 ` kernel test robot
2024-05-11 16:01 ` Jonathan Cameron
2024-05-14 20:25 ` [PATCH v1 0/2] Add TYHX HX9031AS Yasin Lee
[not found] ` <20240514202540.341103-1-yasin.lee.x@outlook.com>
2024-05-14 20:25 ` [PATCH v1 1/2] iio:proximity:hx9031as: Add TYHX HX9031AS/HX9023S sensor driver Yasin Lee
2024-05-15 8:07 ` Krzysztof Kozlowski
2024-05-16 20:57 ` kernel test robot
2024-05-19 15:24 ` Jonathan Cameron
2024-05-29 4:57 ` [PATCH v3 0/2] iio-proximity-hx9023s-Add-TYHX-HX9023S-sensor-driver Yasin Lee
2024-05-31 7:52 ` Krzysztof Kozlowski
2024-06-16 7:45 ` Krzysztof Kozlowski [this message]
2024-06-02 13:24 ` Jonathan Cameron
[not found] ` <20240529045749.530039-1-yasin.lee.x@outlook.com>
2024-05-29 4:57 ` [PATCH v3 1/2] dt-bindings:iio:proximity: Add hx9023s binding Yasin Lee
2024-05-31 7:51 ` Krzysztof Kozlowski
2024-06-02 13:34 ` Jonathan Cameron
2024-05-29 4:57 ` [PATCH v3 2/2] iio:proximity:hx9023s: Add TYHX HX9023S sensor driver Yasin Lee
2024-05-29 9:13 ` Andy Shevchenko
2024-05-30 1:06 ` kernel test robot
2024-05-30 16:59 ` kernel test robot
2024-05-30 19:07 ` kernel test robot
2024-06-02 14:26 ` Jonathan Cameron
2024-05-14 20:25 ` [PATCH v1 2/2] dt-bindings:iio:proximity: Add hx9031as binding Yasin Lee
2024-05-15 8:06 ` Krzysztof Kozlowski
2024-06-16 7:47 ` Krzysztof Kozlowski
2024-06-19 8:38 ` Yasin Lee
2024-06-19 9:17 ` Krzysztof Kozlowski
2024-05-11 18:36 ` [PATCH] iio:proximity:hx9031as: Add TYHX HX9031AS/HX9023S sensor driver kernel test robot
2024-05-11 19:18 ` kernel test robot
2024-05-11 19:18 ` kernel test robot
2024-05-11 22:14 ` kernel test robot
2024-05-21 10:05 ` kernel test robot
2024-05-21 11:50 ` kernel test robot
2024-05-23 12:42 ` Dan Carpenter
2024-05-25 14:00 ` Andy Shevchenko
2024-05-27 8:14 ` Dan Carpenter
2024-05-27 8:50 ` Dan Carpenter
2024-05-27 9:07 ` Dan Carpenter
2024-05-31 5:48 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a585d179-d401-4a38-8c6b-f02f3d880d8c@kernel.org \
--to=krzk@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.a@analog.com \
--cc=swboyd@chromium.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yasin.lee.x@gmail.com \
--cc=yasin.lee.x@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).