* [PATCH v1 1/3] iio: light: adux1020: Drop unneeded assignment for cache_type
2025-01-29 15:24 [PATCH v1 0/3] iio: drop useless assignment of cache_type Andy Shevchenko
@ 2025-01-29 15:24 ` Andy Shevchenko
2025-01-29 15:24 ` [PATCH v1 2/3] iio: magnetometer: af8133j: " Andy Shevchenko
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2025-01-29 15:24 UTC (permalink / raw)
To: Jonathan Cameron, Icenowy Zheng, Peter Zijlstra (Intel),
linux-iio, linux-kernel
Cc: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
Ondřej Jirman, Andy Shevchenko
REGCACHE_NONE is the default type of the cache when not provided.
Drop unneeded explicit assignment to it.
Note, it's defined to 0, and if ever be redefined, it will break
literally a lot of the drivers, so it very unlikely to happen.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/iio/light/adux1020.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/light/adux1020.c b/drivers/iio/light/adux1020.c
index 593d614b1689..9240983a6cc4 100644
--- a/drivers/iio/light/adux1020.c
+++ b/drivers/iio/light/adux1020.c
@@ -118,7 +118,6 @@ static const struct regmap_config adux1020_regmap_config = {
.reg_bits = 8,
.val_bits = 16,
.max_register = 0x6F,
- .cache_type = REGCACHE_NONE,
};
static const struct reg_sequence adux1020_def_conf[] = {
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v1 2/3] iio: magnetometer: af8133j: Drop unneeded assignment for cache_type
2025-01-29 15:24 [PATCH v1 0/3] iio: drop useless assignment of cache_type Andy Shevchenko
2025-01-29 15:24 ` [PATCH v1 1/3] iio: light: adux1020: Drop unneeded assignment for cache_type Andy Shevchenko
@ 2025-01-29 15:24 ` Andy Shevchenko
2025-01-29 15:24 ` [PATCH v1 3/3] iio: pressure: zpa2326: " Andy Shevchenko
2025-01-30 8:30 ` [PATCH v1 0/3] iio: drop useless assignment of cache_type Nuno Sá
3 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2025-01-29 15:24 UTC (permalink / raw)
To: Jonathan Cameron, Icenowy Zheng, Peter Zijlstra (Intel),
linux-iio, linux-kernel
Cc: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
Ondřej Jirman, Andy Shevchenko
REGCACHE_NONE is the default type of the cache when not provided.
Drop unneeded explicit assignment to it.
Note, it's defined to 0, and if ever be redefined, it will break
literally a lot of the drivers, so it very unlikely to happen.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/iio/magnetometer/af8133j.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/magnetometer/af8133j.c b/drivers/iio/magnetometer/af8133j.c
index a70bf8a3c73b..c1fc339e85b4 100644
--- a/drivers/iio/magnetometer/af8133j.c
+++ b/drivers/iio/magnetometer/af8133j.c
@@ -383,7 +383,6 @@ static const struct regmap_config af8133j_regmap_config = {
.reg_bits = 8,
.val_bits = 8,
.max_register = AF8133J_REG_SWR,
- .cache_type = REGCACHE_NONE,
};
static void af8133j_power_down_action(void *ptr)
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v1 3/3] iio: pressure: zpa2326: Drop unneeded assignment for cache_type
2025-01-29 15:24 [PATCH v1 0/3] iio: drop useless assignment of cache_type Andy Shevchenko
2025-01-29 15:24 ` [PATCH v1 1/3] iio: light: adux1020: Drop unneeded assignment for cache_type Andy Shevchenko
2025-01-29 15:24 ` [PATCH v1 2/3] iio: magnetometer: af8133j: " Andy Shevchenko
@ 2025-01-29 15:24 ` Andy Shevchenko
2025-01-30 8:30 ` [PATCH v1 0/3] iio: drop useless assignment of cache_type Nuno Sá
3 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2025-01-29 15:24 UTC (permalink / raw)
To: Jonathan Cameron, Icenowy Zheng, Peter Zijlstra (Intel),
linux-iio, linux-kernel
Cc: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
Ondřej Jirman, Andy Shevchenko
REGCACHE_NONE is the default type of the cache when not provided.
Drop unneeded explicit assignment to it.
Note, it's defined to 0, and if ever be redefined, it will break
literally a lot of the drivers, so it very unlikely to happen.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/iio/pressure/zpa2326_i2c.c | 1 -
drivers/iio/pressure/zpa2326_spi.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/iio/pressure/zpa2326_i2c.c b/drivers/iio/pressure/zpa2326_i2c.c
index 49a239ebdabf..a6034bf05d97 100644
--- a/drivers/iio/pressure/zpa2326_i2c.c
+++ b/drivers/iio/pressure/zpa2326_i2c.c
@@ -25,7 +25,6 @@ static const struct regmap_config zpa2326_regmap_i2c_config = {
.precious_reg = zpa2326_isreg_precious,
.max_register = ZPA2326_TEMP_OUT_H_REG,
.read_flag_mask = BIT(7),
- .cache_type = REGCACHE_NONE,
};
static unsigned int zpa2326_i2c_hwid(const struct i2c_client *client)
diff --git a/drivers/iio/pressure/zpa2326_spi.c b/drivers/iio/pressure/zpa2326_spi.c
index 317270fa1c43..c678f5b96266 100644
--- a/drivers/iio/pressure/zpa2326_spi.c
+++ b/drivers/iio/pressure/zpa2326_spi.c
@@ -26,7 +26,6 @@ static const struct regmap_config zpa2326_regmap_spi_config = {
.precious_reg = zpa2326_isreg_precious,
.max_register = ZPA2326_TEMP_OUT_H_REG,
.read_flag_mask = BIT(7) | BIT(6),
- .cache_type = REGCACHE_NONE,
};
static int zpa2326_probe_spi(struct spi_device *spi)
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v1 0/3] iio: drop useless assignment of cache_type
2025-01-29 15:24 [PATCH v1 0/3] iio: drop useless assignment of cache_type Andy Shevchenko
` (2 preceding siblings ...)
2025-01-29 15:24 ` [PATCH v1 3/3] iio: pressure: zpa2326: " Andy Shevchenko
@ 2025-01-30 8:30 ` Nuno Sá
2025-02-01 12:47 ` Jonathan Cameron
3 siblings, 1 reply; 6+ messages in thread
From: Nuno Sá @ 2025-01-30 8:30 UTC (permalink / raw)
To: Andy Shevchenko, Jonathan Cameron, Icenowy Zheng,
Peter Zijlstra (Intel), linux-iio, linux-kernel
Cc: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
Ondřej Jirman
On Wed, 2025-01-29 at 17:24 +0200, Andy Shevchenko wrote:
> Default value is REGCACHE_NONE, no need to assign it explicitly.
> Fix all IIO drivers that do that.
>
> Andy Shevchenko (3):
> iio: light: adux1020: Drop unneeded assignment for cache_type
> iio: magnetometer: af8133j: Drop unneeded assignment for cache_type
> iio: pressure: zpa2326: Drop unneeded assignment for cache_type
>
> drivers/iio/light/adux1020.c | 1 -
> drivers/iio/magnetometer/af8133j.c | 1 -
> drivers/iio/pressure/zpa2326_i2c.c | 1 -
> drivers/iio/pressure/zpa2326_spi.c | 1 -
> 4 files changed, 4 deletions(-)
>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v1 0/3] iio: drop useless assignment of cache_type
2025-01-30 8:30 ` [PATCH v1 0/3] iio: drop useless assignment of cache_type Nuno Sá
@ 2025-02-01 12:47 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2025-02-01 12:47 UTC (permalink / raw)
To: Nuno Sá
Cc: Andy Shevchenko, Jonathan Cameron, Icenowy Zheng,
Peter Zijlstra (Intel), linux-iio, linux-kernel,
Lars-Peter Clausen, Michael Hennerich, Ondřej Jirman
On Thu, 30 Jan 2025 08:30:47 +0000
Nuno Sá <noname.nuno@gmail.com> wrote:
> On Wed, 2025-01-29 at 17:24 +0200, Andy Shevchenko wrote:
> > Default value is REGCACHE_NONE, no need to assign it explicitly.
> > Fix all IIO drivers that do that.
> >
> > Andy Shevchenko (3):
> > iio: light: adux1020: Drop unneeded assignment for cache_type
> > iio: magnetometer: af8133j: Drop unneeded assignment for cache_type
> > iio: pressure: zpa2326: Drop unneeded assignment for cache_type
> >
> > drivers/iio/light/adux1020.c | 1 -
> > drivers/iio/magnetometer/af8133j.c | 1 -
> > drivers/iio/pressure/zpa2326_i2c.c | 1 -
> > drivers/iio/pressure/zpa2326_spi.c | 1 -
> > 4 files changed, 4 deletions(-)
> >
>
> Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Applied.
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 6+ messages in thread