From: Claudiu Beznea <claudiu.beznea@tuxon.dev>
To: Jonathan Cameron <jic23@kernel.org>
Cc: prabhakar.mahadev-lad.rj@bp.renesas.com, lars@metafoo.de,
linux-iio@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
gregkh@linuxfoundation.org
Subject: Re: [PATCH v4 0/2] iio: rzg2l_adc: Cleanups for rzg2l_adc driver
Date: Thu, 27 Mar 2025 18:34:59 +0200 [thread overview]
Message-ID: <a66f3c88-0fe7-4e9c-83cd-1fe4bca8b14e@tuxon.dev> (raw)
In-Reply-To: <20250327153845.6ab73574@jic23-huawei>
Hi, Jonathan,
On 27.03.2025 17:38, Jonathan Cameron wrote:
> On Mon, 24 Mar 2025 14:26:25 +0200
> Claudiu <claudiu.beznea@tuxon.dev> wrote:
>
>> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>>
>> Hi,
>>
>> Series adds some cleanups for the RZ/G2L ADC driver after the support
>> for the RZ/G3S SoC.
>
> This doesn't address Dmitry's comment or highlight the outstanding
> question he had to Greg KH on v3.
> I appreciate you want to get this fixed but I'd rather we got
> it 'right' first time!
My bad. As there was no input on platform bus patch I though this is not
the desired way of going forward. Sorry for that.
>
> Also, please make sure to +CC anyone who engaged with an earlier version.
Ok, will do it.
>
> For reference of Greg if he sees this, Dmitry was expressing view that
> the fix belongs in the bus layer not the individual drivers.
> FWIW that feels like the right layer to me as well.
To me, too.
Thank you,
Claudiu
>
> https://lore.kernel.org/all/Z8k8lDxA53gUJa0n@google.com/#t
>
> Jonathan
>
>
>
>>
>> Thank you,
>> Claudiu Beznea
>>
>> Changes in v4:
>> - open the devres group in its own function and rename the
>> rzg2l_adc_probe() to rzg2l_adc_probe_helper() to have simpler code
>> - collected tags
>>
>> Changes in v3:
>> - in patch 2/2 use a devres group for all the devm resources
>> acquired in the driver's probe
>>
>> Changes in v2:
>> - updated cover letter
>> - collected tags
>> - updated patch 1/2 to drop devres APIs from the point the
>> runtime PM is enabled
>>
>> Claudiu Beznea (2):
>> iio: adc: rzg2l_adc: Open a devres group
>> iio: adc: rzg2l: Cleanup suspend/resume path
>>
>> drivers/iio/adc/rzg2l_adc.c | 67 +++++++++++++++++++++++++------------
>> 1 file changed, 45 insertions(+), 22 deletions(-)
>>
>
prev parent reply other threads:[~2025-03-27 16:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 12:26 [PATCH v4 0/2] iio: rzg2l_adc: Cleanups for rzg2l_adc driver Claudiu
2025-03-24 12:26 ` [PATCH v4 1/2] iio: adc: rzg2l_adc: Open a devres group Claudiu
2025-03-24 12:26 ` [PATCH v4 2/2] iio: adc: rzg2l: Cleanup suspend/resume path Claudiu
2025-03-27 15:38 ` [PATCH v4 0/2] iio: rzg2l_adc: Cleanups for rzg2l_adc driver Jonathan Cameron
2025-03-27 16:22 ` Greg KH
2025-03-30 15:36 ` Jonathan Cameron
2025-05-19 9:59 ` Claudiu Beznea
2025-03-27 16:34 ` Claudiu Beznea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a66f3c88-0fe7-4e9c-83cd-1fe4bca8b14e@tuxon.dev \
--to=claudiu.beznea@tuxon.dev \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox