From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15ECB15EFB4; Mon, 17 Jun 2024 14:42:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718635349; cv=none; b=je8qgWvhTJMoCkbByTX+faTvnbfK3jK+4j542i6zcGh6BWe+gih6nPuGt7Ep0fcl6QeXjceQ3J4NU3fQNUbeMFm8FavfdhVS9NKm43YsGBTrUyvv8L+ig5qclohKtVfinx5URB3LQVvXnXgObRsNq0YQdhyDmW+02bhQBH4YTqQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718635349; c=relaxed/simple; bh=E2YQNX6Tuz8HfUHpOihGxh9fyCb+mnp+I4qgACuBpKE=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=fup+BB14RM6fq+v1Xn+ASJp346Nh9D5m8G8cYlqALdoxjf0OYm5B6H6BkRhe1TCxh/nqvkbL15kOQMvUJV9KlQpTHR4piqEoXPJ5rmvjRDAgsDitULVSVlBmzRHAKT+HZSSZpUCASZRhFqXtXvde/vM4TeXGes7WWnltSpB+gcI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fTkKl7Go; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fTkKl7Go" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-57cce3bc8c6so2410138a12.3; Mon, 17 Jun 2024 07:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718635346; x=1719240146; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=E2YQNX6Tuz8HfUHpOihGxh9fyCb+mnp+I4qgACuBpKE=; b=fTkKl7Go+98ESLVA+cWR/43Utnpy63+1wqWUZTjs8nQuY/6RO/2dhf78J+R0YLj24Q 0u2mDZLuBBOjPJvOCwy7WaseAaHrxqR+DIkfqbAFuu5ue9yQwznuo/9/T2RI3VR7gBD7 /tR9/d/yua4JC76k521xKY1GJp9XqMcWHwiMlwmMzrFEeEuW59xX/lsdKNqNU6yUeWLr /dKk+uFdB3VMhbc7B23TuauMw4Z4FJi+VzdYMQ1gpU0/m7C8KVpc2O8vqCgfR6Gj4+6e ypaWb/jdEF6JkugGrYH58haLkyr5KUxOJq/gKNWXA8z6HMAiIoscMlhjt6tTk6Tt1lLi BAww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718635346; x=1719240146; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=E2YQNX6Tuz8HfUHpOihGxh9fyCb+mnp+I4qgACuBpKE=; b=SreACyD+L0cFlxcaB81kY2+NjcyayBs6gHNh9jyDeAS/40oJRpSdSmPtjeUk5DaUav gkATSOFAQZm2Hg5dImcZ+XBpk6p7WVbYz9Xpf/zPAic5wFABtO2+3a1CAArOdCZS7r8t dHCBeAZtbBcOLHvtaWVNjLUvstUS8h/4a09M/W5/KB+igTQeH6jERVTUVLe+jrO/yxSI C5dAb7MzVx664NdJG5h8KBuZxOkr3xg2Dax/FqUM/G8zdnQ/D8NRkF0vI8Ds+tP63iL1 tGkqXNIzZJWHRmBHCOtDSyXYCmAUgtQViTbqEDBGo7yTMHQKV7pFwOUexb69BK7TtN0T p8uw== X-Forwarded-Encrypted: i=1; AJvYcCXSSfzEpSfy4BRJfhiC/SKDa7RnI8FhDwdnJbGRzGGpeJz5hbTQt+l2SdxG/na3vKmK33SxrMOdAHJ3x0vLjNBd58JdmuY136Tp4c+psdskdbJruz5LviGdJXkgmdCnupxBvHCCi4e3/JiMtQ== X-Gm-Message-State: AOJu0YyCP4MfHnEPorB6DzKZni3VvEEom/os0ORJRAhzKGKZooGbDbQK 6RDhELVMY+PBD9wF5v9l3iPwWt203xVlykp4OJMAdPR5RlKWGe4W X-Google-Smtp-Source: AGHT+IGkzpQ7qdmk73JHhNvar3yzbeO/0JuLTETghlv9ovmWg6RAvgWc3MKokHO04h0aGO4cAJzoZA== X-Received: by 2002:a50:8753:0:b0:578:6378:bc4 with SMTP id 4fb4d7f45d1cf-57cbd69d997mr5941494a12.10.1718635346075; Mon, 17 Jun 2024 07:42:26 -0700 (PDT) Received: from ?IPv6:2001:a61:35f9:9001:40df:88bb:5090:7ab6? ([2001:a61:35f9:9001:40df:88bb:5090:7ab6]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57cb743890dsm6514525a12.83.2024.06.17.07.42.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 07:42:25 -0700 (PDT) Message-ID: Subject: Re: [PATCH v3 04/41] iio: adc: ad4130: make use of regmap_clear_bits() From: Nuno =?ISO-8859-1?Q?S=E1?= To: Trevor Gamblin , Jonathan Cameron , Lars-Peter Clausen , Dmitry Rokosov , Michael Hennerich , Cosmin Tanislav , Chen-Yu Tsai , Hans de Goede , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Saravanan Sekar , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Nuno =?ISO-8859-1?Q?S=E1?= , Linus Walleij , Jean-Baptiste Maneyrol , Crt Mori Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= Date: Mon, 17 Jun 2024 16:42:24 +0200 In-Reply-To: <20240617-review-v3-4-88d1338c4cca@baylibre.com> References: <20240617-review-v3-0-88d1338c4cca@baylibre.com> <20240617-review-v3-4-88d1338c4cca@baylibre.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.2 (3.52.2-1.fc40) Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2024-06-17 at 09:49 -0400, Trevor Gamblin wrote: > Instead of using regmap_update_bits() and passing val =3D 0, use > regmap_clear_bits(). >=20 > Suggested-by: Uwe Kleine-K=C3=B6nig > Signed-off-by: Trevor Gamblin > --- Reviewed-by: Nuno Sa