From: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
To: Arthur Pilone <art.pilone@gmail.com>
Cc: jic23@kernel.org, marcelo.schmitt@analog.com,
linux-iio@vger.kernel.org, bruno.stephan@usp.br, aschwarz@usp.br
Subject: Re: [PATCH v3] iio: adc: ad7091r-base: Remove duplicate code on volatile reg check
Date: Mon, 21 Apr 2025 22:52:25 -0300 [thread overview]
Message-ID: <aAb2WYSkhE3xWqAv@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <20250421145534.91146-1-arthurpilone@usp.br>
Hello Arthur et. al.
This version looks good to me.
Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
On 04/21, Arthur Pilone wrote:
> From: Arthur Pilone <art.pilone@gmail.com>
>
> Both ad7091r_writeable_reg() and ad7091r_volatile_reg() perform the
> same test, checking whether a given 'reg' code is
> AD7091R_REG_RESULT or AD7091R_REG_ALERT. As the volatile ad7091r
> registers happen to be the only read-only ones, the volatile_reg()
> function now returns the negated output of writeable_reg().
>
> Co-developed-by: Bruno Stephan <bruno.stephan@usp.br>
> Signed-off-by: Bruno Stephan <bruno.stephan@usp.br>
> Co-developed-by: Andre de Lima <aschwarz@usp.br>
> Signed-off-by: Andre de Lima <aschwarz@usp.br>
> Signed-off-by: Arthur Pilone <art.pilone@gmail.com>
next prev parent reply other threads:[~2025-04-22 1:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 14:55 [PATCH v3] iio: adc: ad7091r-base: Remove duplicate code on volatile reg check Arthur Pilone
2025-04-22 1:52 ` Marcelo Schmitt [this message]
2025-04-26 15:33 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAb2WYSkhE3xWqAv@debian-BULLSEYE-live-builder-AMD64 \
--to=marcelo.schmitt1@gmail.com \
--cc=art.pilone@gmail.com \
--cc=aschwarz@usp.br \
--cc=bruno.stephan@usp.br \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox