Re: [PATCH v5 3/4] iio: chemical: add support for winsen MHZ19B CO2 sensor

[Andy Shevchenko <andy@kernel.org>]

On Wed, Apr 23, 2025 at 12:53:01AM +0900, Gyeyoung Baek wrote:
> Add support for winsen MHZ19B CO2 sensor.

Winsen (name capitalisation)?

...

> +static ssize_t calibration_forced_value_store(struct device *dev,
> +					      struct device_attribute *attr,
> +					      const char *buf, size_t len)
> +{
> +	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> +	u16 ppm;
> +	int cmd, ret;
> +
> +	ret = kstrtou16(buf, 0, &ppm);
> +	if (ret)
> +		return ret;
> +
> +	if (ppm) {
> +		if (!in_range(ppm, 1000, 4001)) {
> +			dev_dbg(&indio_dev->dev,
> +				"span point ppm should be between 1000 and 5000 inclusive.");
> +			return -EINVAL;
> +		}

I proposed to define the _MIN and _MAX constants for the range and use them in
the parameters. Any objection?

> +		cmd = MHZ19B_SPAN_POINT_CMD;
> +	} else {
> +		cmd = MHZ19B_ZERO_POINT_CMD;
> +	}
> +
> +	ret = mhz19b_serdev_cmd(indio_dev, cmd, ppm);
> +	if (ret < 0)
> +		return ret;
> +
> +	return len;
> +}

Otherwise LGTM, thanks!

-- 
With Best Regards,
Andy Shevchenko