Re: [PATCH v3] iio: light: apds9306: Refactor threshold get/set functions to use helper

[Marcelo Schmitt <marcelo.schmitt1@gmail.com>]

Hello Nattan, Lucas,

This version looks good to me.
One minor thing below.

On 05/26, nattan wrote:
> From: Nattan Ferreira <nattanferreira58@gmail.com>
> 
> Refactor the apds9306_event_thresh_get and apds9306_event_thresh_set
> functions to use a helper function (apds9306_get_thresh_reg) for obtaining the
nitpicking: commit message and description are wrapped to 75 columns.

> correct register based on the direction of the event. This improves code
> readability and maintains consistency
I think part of the description from the line below could also fit into the line above.
> in accessing threshold registers.
> 
> Signed-off-by: Nattan Ferreira <nattanferreira58@gmail.com>
> Co-developed-by: Lucas Antonio <lucasantonio.santos@usp.br>
> Signed-off-by: Lucas Antonio <lucasantonio.santos@usp.br>
> ---
Friendly reminder to add a change log below the --- if you send a v4 (or v5?).

>  drivers/iio/light/apds9306.c | 36 ++++++++++++++++++++----------------
>  1 file changed, 20 insertions(+), 16 deletions(-)
> 

Regards,
Marcelo