From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: jean-baptiste.maneyrol@tdk.com
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] iio: imu: inv_icm42600: add wakeup functionality for Wake-on-Motion
Date: Fri, 13 Jun 2025 11:31:20 +0300 [thread overview]
Message-ID: <aEvh2My32K9us0Tc@smile.fi.intel.com> (raw)
In-Reply-To: <20250613-losd-3-inv-icm42600-add-wom-support-v4-2-7e5f554201bf@tdk.com>
On Fri, Jun 13, 2025 at 09:34:27AM +0200, Jean-Baptiste Maneyrol via B4 Relay wrote:
> From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
>
> When Wake-on-Motion is on, enable system wakeup and keep the chip on
> for waking up the system with an interrupt.
...
> + /* accel events are wakeup capable */
> + devm_device_init_wakeup(&indio_dev->dev);
No checking for return code? Why is it okay? This needs a really good comment,
and even better a (info / debug) message when it fails if it's not a fatal
error.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-13 8:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 7:34 [PATCH v4 0/2] Add support for WoM (Wake-on-Motion) feature Jean-Baptiste Maneyrol via B4 Relay
2025-06-13 7:34 ` [PATCH v4 1/2] iio: imu: inv_icm42600: add WoM support Jean-Baptiste Maneyrol via B4 Relay
2025-06-13 8:29 ` Andy Shevchenko
2025-06-13 12:46 ` Jean-Baptiste Maneyrol
2025-06-13 12:53 ` Andy Shevchenko
2025-06-13 12:54 ` Andy Shevchenko
2025-06-13 13:43 ` Jean-Baptiste Maneyrol
2025-06-13 14:41 ` Andy Shevchenko
2025-06-13 15:01 ` Andy Shevchenko
2025-06-13 17:14 ` Jean-Baptiste Maneyrol
2025-06-13 21:02 ` Andy Shevchenko
2025-06-14 12:41 ` Jonathan Cameron
2025-06-14 12:53 ` Jonathan Cameron
2025-06-16 7:42 ` Jean-Baptiste Maneyrol
2025-06-21 17:07 ` Jonathan Cameron
2025-06-13 7:34 ` [PATCH v4 2/2] iio: imu: inv_icm42600: add wakeup functionality for Wake-on-Motion Jean-Baptiste Maneyrol via B4 Relay
2025-06-13 8:31 ` Andy Shevchenko [this message]
2025-06-13 11:42 ` Jean-Baptiste Maneyrol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEvh2My32K9us0Tc@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox