From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Lechner <dlechner@baylibre.com>, Hans de Goede <hansg@kernel.org>
Cc: "Marek Vasut" <marek.vasut+bmc150@mailbox.org>,
linux-iio@vger.kernel.org, "Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"Julien Stephan" <jstephan@baylibre.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Salvatore Bonaccorso" <carnil@debian.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: accel: bmc150: Do not configure IRQ registers if no IRQ connected
Date: Fri, 13 Jun 2025 18:09:54 +0300 [thread overview]
Message-ID: <aEw_QrVk9m1TJof3@smile.fi.intel.com> (raw)
In-Reply-To: <8f7656ed-0a28-4ba0-accc-b19817bbb38b@baylibre.com>
+Hans here as well.
On Fri, Jun 13, 2025 at 10:03:34AM -0500, David Lechner wrote:
> On 6/13/25 7:45 AM, Marek Vasut wrote:
> > The BMC150 on Onemix 2S does not have IRQ line described in ACPI tables,
> > which leads to bmc150_accel_core_probe() being called with irq=0, which
> > leads to bmc150_accel_interrupts_setup() never being called, which leads
> > to struct bmc150_accel_data *data ->interrupts[i].info being left unset
> > to NULL. Later, userspace can indirectly trigger bmc150_accel_set_interrupt()
> > which depends on struct bmc150_accel_data *data ->interrupts[i].info being
> > non-NULL, and which triggers NULL pointer dereference. This is triggered
> > e.g. from iio-sensor-proxy.
>
> Is the interrupt not wired up or is it just missing from the table?
Same Q I just asked :-)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-13 15:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 12:45 [PATCH] iio: accel: bmc150: Do not configure IRQ registers if no IRQ connected Marek Vasut
2025-06-13 15:03 ` David Lechner
2025-06-13 15:09 ` Andy Shevchenko [this message]
2025-06-13 15:09 ` Andy Shevchenko
2025-06-13 17:02 ` Marek Vasut
2025-06-14 13:03 ` Jonathan Cameron
2025-06-16 8:47 ` Andy Shevchenko
2025-06-16 11:03 ` Marek Vasut
2025-06-16 11:09 ` Andy Shevchenko
2025-06-21 17:33 ` Marek Vasut
2025-06-23 7:19 ` Andy Shevchenko
2025-06-16 12:42 ` Hans de Goede
2025-06-21 17:17 ` Jonathan Cameron
2025-06-21 17:24 ` Marek Vasut
2025-06-21 20:14 ` Hans de Goede
2026-01-08 21:55 ` Marek Vasut
2026-01-09 9:24 ` Linus Walleij
2026-01-09 15:00 ` Marek Vasut
2025-07-22 8:55 ` Uwe Kleine-König
2025-07-22 14:48 ` Marek Vasut
2025-07-23 15:19 ` Andy Shevchenko
2025-10-01 18:25 ` Salvatore Bonaccorso
2025-11-15 18:23 ` Jonathan Cameron
2025-07-24 13:41 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEw_QrVk9m1TJof3@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=carnil@debian.org \
--cc=dlechner@baylibre.com \
--cc=hansg@kernel.org \
--cc=jic23@kernel.org \
--cc=jstephan@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut+bmc150@mailbox.org \
--cc=nuno.sa@analog.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox