Re: [PATCH v1 0/2] Add BMP390 IIO driver, device tree bindings and support

[Vasileios Amoiridis <vassilisamir@gmail.com>]

On Sun, Jun 22, 2025 at 04:06:37PM +0100, Jonathan Cameron wrote:
> On Fri, 20 Jun 2025 10:24:53 +0530
> <liquancin.mereenamathai@in.bosch.com> wrote:
> 
> > From: Liquancin Mereena Mathai <liquancin.mereenamathai@in.bosch.com>
> > 
> > This patch series adds support for the Bosch BMP390 pressure sensor to the
> > Linux IIO subsystem. It includes the main driver implementation as well as
> > the necessary device tree bindings for integration on supported platforms.
> 
> Hi Liquancin, 
> 
> Great to see this driver.  However, it is huge which will make it very challenging
> to review.  I'll take a first look but in general you need to break this up
> into more manageable steps of building up driver complexity.  The driver
> must work and be useful at each step, but the usual approach is to introduce
> first a fairly minimal driver that does basic measurements only and then build
> up from there.  If any patch is getting substantially over 1000 lines of code
> then it becomes unmanageable without reviewers dedicating a significant chunk
> of their day to that review and hence them finding that time can take a while
> if it happens at all.
> 
> Only exception to this is that the dt binding should be as complete
> as possible from the start.
> 
> Jonathan
> 

Hi all,

The BMP39x sensor is almost 100% identical to the BMP38x sensor for
which there is a driver under drivers/iio/pressure/bmp280-core.c. This
driver also supports the previous BMP28x, the next generation BMP58x and
the humidity sensor BME280.

The register maps betweem BMP384, BMP388 and BMP390 look almost 100%
identical. You can check also here [1,2,3].

Liquacin, did you try to see if you could use the aforementioned driver
to control your BMP390 device?

Cheers,
Vasilis

[1]: https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmp384-ds003.pdf#page=29
[2]: https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmp388-ds001.pdf#page=30
[3]: https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmp390-ds002.pdf#page=30

> > 
> > Patch 1 adds the IIO driver for the BMP390 pressure sensor.
> > Patch 2 introduces the device tree bindings documentation.
> > 
> > Liquancin Mereena Mathai (2):
> >   Add the iio driver for bosch pressure sensor bmp390. The bmp390 is a
> >     pressure sensor module. It will support SPI and I2C protocol based
> >     on configuration.
> >   dt-bindings: iio driver: Add BMP390 pressure sensor device tree
> >     binding
> > 
> >  .../bindings/iio/pressure/bosch,bmp390.yaml   |   65 +
> >  MAINTAINERS                                   |    7 +
> >  drivers/iio/pressure/Kconfig                  |   26 +
> >  drivers/iio/pressure/Makefile                 |    1 +
> >  drivers/iio/pressure/bmp390/Kconfig           |   29 +
> >  drivers/iio/pressure/bmp390/Makefile          |   32 +
> >  drivers/iio/pressure/bmp390/bmp3.c            | 2781 +++++++++++++++++
> >  drivers/iio/pressure/bmp390/bmp3.h            |  537 ++++
> >  drivers/iio/pressure/bmp390/bmp390_driver.c   | 1604 ++++++++++
> >  drivers/iio/pressure/bmp390/bmp390_driver.h   |  232 ++
> >  drivers/iio/pressure/bmp390/bmp390_i2c.c      |  328 ++
> >  .../iio/pressure/bmp390/bmp390_iio_buffer.c   |  220 ++
> >  drivers/iio/pressure/bmp390/bmp390_spi.c      |  286 ++
> >  drivers/iio/pressure/bmp390/bmp3_defs.h       |  871 ++++++
> >  drivers/iio/pressure/bmp390/bmp3_selftest.c   |  184 ++
> >  drivers/iio/pressure/bmp390/bmp3_selftest.h   |   93 +
> >  16 files changed, 7296 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/iio/pressure/bosch,bmp390.yaml
> >  create mode 100644 drivers/iio/pressure/bmp390/Kconfig
> >  create mode 100644 drivers/iio/pressure/bmp390/Makefile
> >  create mode 100644 drivers/iio/pressure/bmp390/bmp3.c
> >  create mode 100644 drivers/iio/pressure/bmp390/bmp3.h
> >  create mode 100644 drivers/iio/pressure/bmp390/bmp390_driver.c
> >  create mode 100644 drivers/iio/pressure/bmp390/bmp390_driver.h
> >  create mode 100644 drivers/iio/pressure/bmp390/bmp390_i2c.c
> >  create mode 100644 drivers/iio/pressure/bmp390/bmp390_iio_buffer.c
> >  create mode 100644 drivers/iio/pressure/bmp390/bmp390_spi.c
> >  create mode 100644 drivers/iio/pressure/bmp390/bmp3_defs.h
> >  create mode 100644 drivers/iio/pressure/bmp390/bmp3_selftest.c
> >  create mode 100644 drivers/iio/pressure/bmp390/bmp3_selftest.h
> > 
>