From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Lechner <dlechner@baylibre.com>
Cc: "Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH 2/9] iio: adc: ad_sigma_delta: use u8 instead of uint8_t
Date: Mon, 23 Jun 2025 09:51:36 +0300 [thread overview]
Message-ID: <aFj5eEvn2uw_HSl0@smile.fi.intel.com> (raw)
In-Reply-To: <20250620-iio-adc-ad7173-add-spi-offload-support-v1-2-0766f6297430@baylibre.com>
On Fri, Jun 20, 2025 at 05:20:08PM -0500, David Lechner wrote:
> Replace uint8_t with u8 in the ad_sigma_delta driver.
>
> Technically, uint8_t comes from the C standard library, while u8 is a
> Linux kernel type. Since we don't use the C standard library in the
> kernel, we should use the kernel types instead.
...
> unsigned int reset_length = sigma_delta->info->num_resetclks;
> - uint8_t *buf;
> + u8 *buf;
> unsigned int size;
> int ret;
Wondering if in the cases like this we may make it to be reversed xmas tree.
unsigned int reset_length = sigma_delta->info->num_resetclks;
unsigned int size;
u8 *buf;
int ret;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-23 6:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 22:20 [PATCH 0/9] iio: adc: ad7173: add SPI offload support David Lechner
2025-06-20 22:20 ` [PATCH 1/9] iio: adc: ad_sigma_delta: sort includes David Lechner
2025-06-22 14:37 ` Jonathan Cameron
2025-06-23 6:50 ` Andy Shevchenko
2025-06-20 22:20 ` [PATCH 2/9] iio: adc: ad_sigma_delta: use u8 instead of uint8_t David Lechner
2025-06-23 6:51 ` Andy Shevchenko [this message]
2025-06-23 21:48 ` David Lechner
2025-06-24 7:20 ` Andy Shevchenko
2025-06-20 22:20 ` [PATCH 3/9] iio: adc: ad_sigma_delta: use BITS_TO_BYTES() macro David Lechner
2025-06-22 14:39 ` Jonathan Cameron
2025-06-23 6:54 ` Andy Shevchenko
2025-06-27 23:36 ` David Lechner
2025-06-20 22:20 ` [PATCH 4/9] iio: adc: ad_sigma_delta: refactor setting read address David Lechner
2025-06-20 22:20 ` [PATCH 5/9] iio: adc: ad_sigma_delta: use spi_optimize_message() David Lechner
2025-06-22 14:50 ` Jonathan Cameron
2025-06-23 6:57 ` Andy Shevchenko
2025-06-20 22:20 ` [PATCH 6/9] dt-bindings: trigger-source: add ADI Util Sigma-Delta SPI David Lechner
2025-06-27 19:59 ` Rob Herring (Arm)
2025-06-20 22:20 ` [PATCH 7/9] spi: offload trigger: add ADI Util Sigma-Delta SPI driver David Lechner
2025-06-20 22:20 ` [PATCH 8/9] iio: adc: ad_sigma_delta: add SPI offload support David Lechner
2025-06-22 15:00 ` Jonathan Cameron
2025-06-22 16:14 ` David Lechner
2025-06-23 10:21 ` kernel test robot
2025-06-23 13:55 ` kernel test robot
2025-06-20 22:20 ` [PATCH 9/9] iio: adc: ad7173: " David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFj5eEvn2uw_HSl0@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).