Linux IIO development
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Sean Nyekjaer <sean@geanix.com>
Cc: "Jean-Baptiste Maneyrol" <jean-baptiste.maneyrol@tdk.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] iio: imu: inv_icm42600: Remove redundant error msg on regulator_disable()
Date: Thu, 10 Jul 2025 16:07:26 +0300	[thread overview]
Message-ID: <aG-7DrG4Jku5q-72@smile.fi.intel.com> (raw)
In-Reply-To: <pt3qh3xaxvbaf7ojib474d7cpgpcehuhzfj6qfg6qv2ivcbb7z@iyen7qvzd7zo>

On Thu, Jul 10, 2025 at 10:47:08AM +0000, Sean Nyekjaer wrote:
> On Thu, Jul 10, 2025 at 12:03:26PM +0100, Andy Shevchenko wrote:
> > On Wed, Jul 09, 2025 at 02:35:11PM +0200, Sean Nyekjaer wrote:
> > > The regulator framework already emits an error message when
> > > regulator_disable() fails, making the local dev_err() redundant.
> > > Remove the duplicate message to avoid cluttering the kernel log
> > > with the same error twice.
> > 
> > To me this sounds like a potential backporting material as it might full
> > the logs (in case the module probed-removed zillion of time. Hence,
> > I would put it to be the first patch in the series (yes, it will involve
> > to fix something that you are removing in the following change, but still).
> 
> I have never seen this printed, so I don't think it's a huge issue.
> But it's quite easy to add a Fixes tag if prefered.

Or move it to the end and explain in cover letter that this doesn't fix
(apparently) any problem IRL.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-07-10 13:07 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-09 12:35 [PATCH 0/6] iio: imu: inv_icm42600: pm_runtime fixes + various changes Sean Nyekjaer
2025-07-09 12:35 ` [PATCH 1/6] iio: imu: inv_icm42600: Use inv_icm42600_disable_vddio_reg() Sean Nyekjaer
2025-07-13 14:17   ` Jonathan Cameron
2025-07-09 12:35 ` [PATCH 2/6] iio: imu: inv_icm42600: Use devm_regulator_get_enable() for vdd regulator Sean Nyekjaer
2025-07-13 14:19   ` Jonathan Cameron
2025-07-09 12:35 ` [PATCH 3/6] iio: imu: inv_icm42600: Remove redundant error msg on regulator_disable() Sean Nyekjaer
2025-07-10  9:03   ` Andy Shevchenko
2025-07-10 10:47     ` Sean Nyekjaer
2025-07-10 13:07       ` Andy Shevchenko [this message]
2025-07-13 14:22   ` Jonathan Cameron
2025-07-09 12:35 ` [PATCH 4/6] iio: imu: inv_icm42600: Simplify pm_runtime setup Sean Nyekjaer
2025-07-10  9:08   ` Andy Shevchenko
2025-07-10 10:45     ` Sean Nyekjaer
2025-07-10 12:23       ` Andy Shevchenko
2025-07-13 14:28   ` Jonathan Cameron
2025-07-14  7:24     ` Sean Nyekjaer
2025-07-14  7:42       ` Sean Nyekjaer
2025-07-16  8:00         ` Jonathan Cameron
2025-07-18  6:40           ` Sean Nyekjaer
2025-07-19 11:47             ` Jonathan Cameron
2025-07-19 13:32               ` Jonathan Cameron
2025-08-08 13:42                 ` Sean Nyekjaer
2025-07-09 12:35 ` [PATCH 5/6] iio: imu: inv_icm42600: Drop redundant pm_runtime reinitialization in resume Sean Nyekjaer
2025-07-09 12:35 ` [PATCH 6/6] iio: imu: inv_icm42600: Avoid configuring if already pm_runtime suspended Sean Nyekjaer
2025-07-10  9:11   ` Andy Shevchenko
2025-07-13 14:32   ` Jonathan Cameron
2025-07-14 10:15     ` Sean Nyekjaer
2025-07-16  8:06       ` Jonathan Cameron
2025-07-10  9:12 ` [PATCH 0/6] iio: imu: inv_icm42600: pm_runtime fixes + various changes Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aG-7DrG4Jku5q-72@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jean-baptiste.maneyrol@tdk.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=sean@geanix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox