From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, "Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Denis Ciocca" <denis.ciocca@st.com>,
"Vasileios Amoiridis" <vassilisamir@gmail.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 0/7] IIO: More application of IWYU principles to includes.
Date: Thu, 10 Jul 2025 22:09:06 +0300 [thread overview]
Message-ID: <aHAP0rr1VQX8hWC9@smile.fi.intel.com> (raw)
In-Reply-To: <20250710171107.443790-1-jic23@kernel.org>
On Thu, Jul 10, 2025 at 06:11:00PM +0100, Jonathan Cameron wrote:
>
> I decided to look at a slightly larger set to continue trying to come
> up with consistent rules (for IIO anyway) on what we want to include
> direclty and what assumptions we can make about a header always including
> another.
>
> As the series goes on reduce the amount of info on particular choices made
> just because the commit descriptions were getting very long.
>
> A few open questions.
> - linux/stddef.h - do we want to included this directly?
Only if not types.h included.
> - linux/types.h - do we want to include this directly?
Yes.
> - linux/dev_printk.h - include even if device.h is needed for other reasons
> or rely on that as a grouping header if present and only use dev_printk
> where we don't need device.h.
I slightly tend to include both as strictly speaking the dev_printk.h should be
device/printk.h, but that boat already sailed long time ago...
> I'll share a refreshed IWYU config once we come to firmer conclusions
> on the various choices. I haven't yet figured out now to not include
> anything at all for things like CONFIG*
PAGE_SIZE is in asm/page.h.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-07-10 19:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 17:11 [PATCH 0/7] IIO: More application of IWYU principles to includes Jonathan Cameron
2025-07-10 17:11 ` [PATCH 1/7] iio: pressure: bmp280: Apply iwyu " Jonathan Cameron
2025-07-10 19:09 ` Andy Shevchenko
2025-07-10 17:11 ` [PATCH 2/7] iio: pressure: zpa2326: " Jonathan Cameron
2025-07-10 17:11 ` [PATCH 3/7] iio: pressure: mpl115: " Jonathan Cameron
2025-07-10 17:11 ` [PATCH 4/7] iio: pressure: ms5611: " Jonathan Cameron
2025-07-10 17:11 ` [PATCH 5/7] iio: pressure: hsc030pa: Apply IWYU " Jonathan Cameron
2025-07-10 17:11 ` [PATCH 6/7] iio: pressure: mprls0025pa: " Jonathan Cameron
2025-07-10 17:11 ` [PATCH 7/7] iio: st_sensors: " Jonathan Cameron
2025-07-10 19:09 ` Andy Shevchenko [this message]
2025-07-10 19:28 ` [PATCH 0/7] IIO: More application of " David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHAP0rr1VQX8hWC9@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy@kernel.org \
--cc=denis.ciocca@st.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=vassilisamir@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).