From: Dan Carpenter <dan.carpenter@linaro.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Waqar Hameed" <waqar.hameed@axis.com>,
"Song Qiang" <songqiang1304521@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH next] io: proximity: vl53l0x-i2c: Fix error code in probe()
Date: Tue, 19 Aug 2025 18:02:00 +0300 [thread overview]
Message-ID: <aKSR6MMr9aKWw9ff@stanley.mountain> (raw)
In-Reply-To: <CAHp75VeTL7mJ-Ttgpkjd5A04DgHqkkPY90LtJriQjoaUZ0TbhQ@mail.gmail.com>
On Tue, Aug 19, 2025 at 01:18:35PM +0300, Andy Shevchenko wrote:
> On Tue, Aug 19, 2025 at 12:39 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
> >
> > Commit 65e8202f0322 ("iio: Remove error prints for
> > devm_add_action_or_reset()") accidentally introduce a bug where we
>
> introduced
>
> > returned "ret" but the error code was stored in "error" if
> > devm_add_action_or_reset() failed. Using two variables to store error
> > codes is unnecessary and confusing. Delete the "error" variable and use
> > "ret" everywhere instead.
>
> Agree, this is a good catch!
> But please, fix the Subject to start with "iio:".
>
> With the above comments being addressed
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
Yeah. :( Thanks. Will do.
regards,
dan carpenter
prev parent reply other threads:[~2025-08-19 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 9:39 [PATCH next] io: proximity: vl53l0x-i2c: Fix error code in probe() Dan Carpenter
2025-08-19 10:18 ` Andy Shevchenko
2025-08-19 15:02 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKSR6MMr9aKWw9ff@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=songqiang1304521@gmail.com \
--cc=waqar.hameed@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox