From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3BD02EE286; Fri, 22 Aug 2025 09:41:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755855691; cv=none; b=gTbsDV+00uz5fW6UsSs040Mk+66xnuItKft/m1sKn15uRYvnsMUBhupWiaa4DHJme2FjP46OG19SHuTmfTfsDiE6jImXtuq57aDLwsETLxup4SDhdWiXeMchKM5PdIP3QOGGi4FXEQ1SnmMNFQXG8IUmdO2yPBvitAia2GAkUD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755855691; c=relaxed/simple; bh=RZKftV/2n/t5kgoSakypDVxhxqhMEzE7Gy6hWmya91U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OuQLzquTWRKFcefRmTSe8eplSCJlnNB0LiiLrqJgmpG9QpaV7EqvM1Yu4wda8JrZbbZFLIFsthH0vNL2PVav3S8R8BehdqamYNDGjzKF/YnpxTA0IMi929rcSliZ80uRaml7sGbMKNHE2biYE9QIDvqbvMO41mSZVp+CzXycQOo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=QOt7Sl4F; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="QOt7Sl4F" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1755855690; x=1787391690; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=RZKftV/2n/t5kgoSakypDVxhxqhMEzE7Gy6hWmya91U=; b=QOt7Sl4FI+/gwek72VSCovIXtpyoAvoI4WB4gykS6kQ4F24vtqS7Zg85 QZpNqVLfEe8A6KvtM9d/1nZZIKDKQuvA+fNktetqtT3YfSvyvL/vKRjsP RYbR9NrFQKYHsy07RASi5N9SuxYh+oIIWxY52pcadXQZR5J4ufzU1YvST RwP4hVick6vrl9YRj/nuO2zXf/NeCNMWnOIpCQiXusFTHKuVhyjHnsBoh cWtp6konsYLNC17SG4qfCbMmCxTMaGOfJ8LbDfGKH4SEFoUbZKyGXXxrD vMREkU2r7dqCQsa/wlzaE/A79HmcTXU2dBi4/M1vs3WXK4qbsiZZdGT3J g==; X-CSE-ConnectionGUID: GLEIF0/8QW6sLS9Ocwwf3w== X-CSE-MsgGUID: T87sE9eFTj2jZk1r1+7Jzw== X-IronPort-AV: E=McAfee;i="6800,10657,11529"; a="61994838" X-IronPort-AV: E=Sophos;i="6.17,309,1747724400"; d="scan'208";a="61994838" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2025 02:41:29 -0700 X-CSE-ConnectionGUID: 7dUmcja+THqiuGqu0CivaA== X-CSE-MsgGUID: 0REQ5MhYReu1rNaxxngBzg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,309,1747724400"; d="scan'208";a="172857947" Received: from smile.fi.intel.com ([10.237.72.52]) by orviesa003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2025 02:41:23 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1upOGs-00000007To4-2PQ4; Fri, 22 Aug 2025 12:41:18 +0300 Date: Fri, 22 Aug 2025 12:41:18 +0300 From: Andy Shevchenko To: Dixit Parmar Cc: Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Ray Jui , Scott Branden , Broadcom internal kernel review list , Support Opensource , Krzysztof Kozlowski , Alim Akhtar , Haibo Chen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Cai Huoqing , Maxime Coquelin , Alexandre Torgue , Andreas Klinger , Crt Mori , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, imx@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH 02/10] iio: adc: Drop unnecessary -ENOMEM messages Message-ID: References: <20250822-enomam_logs-v1-0-db87f2974552@gmail.com> <20250822-enomam_logs-v1-2-db87f2974552@gmail.com> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250822-enomam_logs-v1-2-db87f2974552@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Fri, Aug 22, 2025 at 09:19:50AM +0530, Dixit Parmar wrote: > The drivers do not require their own error messages for error > -ENOMEM, memory allocation failures. So remove the dev_err > messages from the probe(). ... > indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*ddata)); > - if (!indio_dev) { > - dev_err(&pdev->dev, "failed to allocate iio device\n"); > - > + if (!indio_dev) > return -ENOMEM; > - } > + > ddata = iio_priv(indio_dev); > ddata->ato = device_get_match_data(&pdev->dev); > if (!ddata->ato) Looking at this hunk I'm wondering if you are using --histogram diff algo when preparing patches. If not, please do for the next version. -- With Best Regards, Andy Shevchenko