From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Ioana Risteiu <Ioana.Risteiu@analog.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Ramona Nechita" <ramona.nechita@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/4] iio: adc: extract setup function without backend
Date: Mon, 25 Aug 2025 16:45:23 +0300 [thread overview]
Message-ID: <aKxo87Pey5nzlP5G@smile.fi.intel.com> (raw)
In-Reply-To: <20250825105121.19848-4-Ioana.Risteiu@analog.com>
On Mon, Aug 25, 2025 at 01:51:18PM +0300, Ioana Risteiu wrote:
> Refactor probe function by moving the initialization specific to
> communication without iio-backend into a separate setup function.
>
> The purpose of this modification is better code organization. No
> functional changes intended.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
But there is a nit-pick.
...
> indio_dev->name = st->chip_info->name;
> - indio_dev->info = &ad7779_info;
> indio_dev->modes = INDIO_DIRECT_MODE;
> - indio_dev->channels = st->chip_info->channels;
> indio_dev->num_channels = ARRAY_SIZE(ad7779_channels);
Hmm... Not sure about this split, as I would definitely keep logically coupled
things together, like channels and num_channels. Otherwise it will be harder
to maintain and more prone to subtle mistakes.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-08-25 13:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 10:51 [PATCH v5 0/4] Add IIO backend support for AD7779 Ioana Risteiu
2025-08-25 10:51 ` [PATCH v5 1/4] iio: adc: adi-axi-adc: add axi_adc_num_lanes_set Ioana Risteiu
2025-08-25 13:42 ` Andy Shevchenko
2025-08-25 10:51 ` [PATCH v5 2/4] dt-bindings: iio: adc: add IIO backend support Ioana Risteiu
2025-08-25 10:51 ` [PATCH v5 3/4] iio: adc: extract setup function without backend Ioana Risteiu
2025-08-25 13:45 ` Andy Shevchenko [this message]
2025-08-25 10:51 ` [PATCH v5 4/4] iio: adc: update ad7779 to use IIO backend Ioana Risteiu
2025-08-25 13:48 ` Andy Shevchenko
2025-08-25 14:47 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKxo87Pey5nzlP5G@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Ioana.Risteiu@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=ramona.nechita@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).